500 error returned on invalid table name

Bug #1375463 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Medium
Samta Rangare

Bug Description

The following command results in a 500 error in congress. Instead we should return 404 table not found:

nicira@Ubuntu1404Server:~/devstack$ openstack congress datasource table list invalid_name
ERROR: openstack Internal Server Error (HTTP 500) (Request-ID: req-e830229a-27db-4a95-8ee3-889f06fcf220)

2014-09-29 13:42:13.380 ERROR congress.api.application [req-e830229a-27db-4a95-8ee3-889f06fcf220 admin f836b4731b9e483f99274e69f946cd5a] Traceback (most recent call last):
  File "/opt/stack/congress/congress/api/application.py", line 50, in __call__
    response = handler.handle_request(request)
  File "/opt/stack/congress/congress/api/webservice.py", line 319, in handle_request
    return self.list_members(request)
  File "/opt/stack/congress/congress/api/webservice.py", line 345, in list_members
    raise TypeError("Invalid response from data model")
TypeError: Invalid response from data model

Tim Hinrichs (thinrichs)
Changed in congress:
importance: Undecided → Medium
Samta Rangare (srangare)
Changed in congress:
assignee: nobody → Samta Rangare (srangare)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138259

Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/138259
Committed: https://git.openstack.org/cgit/stackforge/congress/commit/?id=4efeb5dacddd0b11604ae732a9660dbd180fc130
Submitter: Jenkins
Branch: master

commit 4efeb5dacddd0b11604ae732a9660dbd180fc130
Author: Samta <email address hidden>
Date: Tue Dec 2 10:34:03 2014 +0530

    500 error returned on invalid table name

    Querying an invalid table name returns 500 error
    (Invalid response from server), but it should actually
    return 404 (Not Found)
    This bug also handle querying for invalid status list.

    Change-Id: I1f953f8211883e4a850777ecdf23f28f2b7a20b5
    Closes-Bug: #1375463

Changed in congress:
status: In Progress → Fix Committed
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → kilo-3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.