getRecurrenceString() function needs to be rewritten

Bug #1372054 reported by David Planella
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Calendar App
Fix Released
Medium
Mihir Soni

Bug Description

The getRecurrenceString() suffers from different issues:

- It doesn't have translatable strings for recurring events happening weekly on a given day
- It uses chained ? : statements that make the code difficult to read (where if/else statements could be used)
- It redefines Qt enums as numerical indexes to be used for different purposes, indexing global arrays outside of the function. That makes the code extremely difficult to follow, and very prone to errors.

I'd suggest reviewing and rewriting it addressing those issues.

Related branches

David Planella (dpm)
Changed in ubuntu-calendar-app:
status: New → Triaged
importance: Undecided → Medium
description: updated
Mihir Soni (mihirsoni)
Changed in ubuntu-calendar-app:
assignee: nobody → Mihir Soni (mihirsoni)
milestone: none → rtm14
Mihir Soni (mihirsoni)
Changed in ubuntu-calendar-app:
status: Triaged → In Progress
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-calendar-app at revision 496, scheduled for release in ubuntu-calendar-app, milestone rtm14

Changed in ubuntu-calendar-app:
status: In Progress → Fix Committed
Changed in ubuntu-calendar-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.