OpenStack Identity (keystone)

Spelling errors in comments in test_backend_ldap.py

Bug #1371499 reported by Henry Nash on 2014-09-19

6

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Identity (keystone)	Fix Released	Low	Steve Martinelli	OpenStack Identity (keystone) 2014.2 "juno"

Bug Description

Some minor spelling mistakes could use correcting, namely:

        # Domain3 has a user created before we switched on
        # multiple backends, plus one created afterwards - and it's
        # backend has not changed - so we should fined two.

Two mistakes in the same block!

Tags:

Henry Nash (henry-nash) on 2014-09-19

Changed in keystone:
importance:	Undecided → Low

Henry Nash (henry-nash) on 2014-09-19

Changed in keystone:
assignee:	nobody → TAHMINA AHMED (tahmina-csebuet)

Henry Nash (henry-nash) on 2014-09-19

tags:	added: test
tags:	added: test-improvement removed: test

Lance Bragstad (lbragstad) on 2014-09-19

tags:

added: low-hanging-fruit

Morgan Fainberg (mdrnstm) on 2014-09-21

Changed in keystone:
status:	New → Confirmed

Revision history for this message

Steve Martinelli (stevemar) wrote on 2014-09-21:

#1

I'm assuming the correct text is:

  # domain3 had a user created before we switched on
  # multiple backends, plus one created afterwards - and its
  # backend has not changed - so we should find two.

summary:

- Spelling erros in comments in test_backend_ldap.py
+ Spelling errors in comments in test_backend_ldap.py

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-09-21: Fix proposed to keystone (master)

#2

Fix proposed to branch: master
Review: https://review.openstack.org/122990

Changed in keystone:
assignee:	TAHMINA AHMED (tahmina-csebuet) → Steve Martinelli (stevemar)
status:	Confirmed → In Progress

Revision history for this message

Henry Nash (henry-nash) wrote on 2014-09-21:

#3

Actually I had explicitly assigned this to Tahmina as part of her starting to work on Keystone as part of the OPW program and she had started working on it. In general, I suggest we really need to leave long handing fruit to help new contributors to start their journey.

Revision history for this message

Steve Martinelli (stevemar) wrote on 2014-09-21:

#4

Henry, sorry about that! I had no idea. I was trying to lower the bug count =\
I agree with what you say about new contributors and low hanging fruit.

Revision history for this message

Henry Nash (henry-nash) wrote on 2014-09-22:

#5

No problem...let's push this one through...I've assigned a different one to Tahmina in its place.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-09-23: Fix merged to keystone (master)

#6

Reviewed: https://review.openstack.org/122990
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=15263f3d1af3273279bcdd724d439bd1f0474deb
Submitter: Jenkins
Branch: master

commit 15263f3d1af3273279bcdd724d439bd1f0474deb
Author: Steve Martinelli <email address hidden>
Date: Sun Sep 21 02:54:17 2014 -0400

Fix minor spelling issues in comments

Change-Id: I46e8cd74dd2af409d502b04843ca17ef63e7e2e1
Closes-Bug: #1371499

Changed in keystone:
status:	In Progress → Fix Committed

Dolph Mathews (dolph) on 2014-09-26

Changed in keystone:
milestone:	none → juno-rc1

Thierry Carrez (ttx) on 2014-09-30

Changed in keystone:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2014-10-16

Changed in keystone:
milestone:	juno-rc1 → 2014.2

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.