fakeldap search with SUBTREE scope does not return the base entry

Bug #1368772 reported by Richard Megginson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Nathan Kinder

Bug Description

An LDAP search with scope SUBTREE must return the base entry specified in the search request. The BaseLdap.search_s method does not do this. The fix in that method is simple:

- results = []
+ results = [(base, item_dict)]

Unfortunately, there are some tests that fail because they expect the broken behavior. Those tests will also need to be fixed.

tags: added: test-improvement
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121370

Changed in keystone:
assignee: nobody → Brant Knudson (blk-u)
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
Changed in keystone:
assignee: Brant Knudson (blk-u) → Nathan Kinder (nkinder)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/121370
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=637845df1ef857dfd5f23658ac77312f0212c7c7
Submitter: Jenkins
Branch: master

commit 637845df1ef857dfd5f23658ac77312f0212c7c7
Author: Brant Knudson <email address hidden>
Date: Sat Sep 13 13:43:43 2014 -0500

    Enhance FakeLdap to require base entry for subtree search

    The FakeLdap implementation didn't raise ldap.NO_SUCH_OBJECT when the
    base entry didn't exist. A real LDAP server would raise if the base
    entry didn't exist.

    Change-Id: If26d4cff5882ad13c9e00b8a894920f244238c49
    Closes-Bug: #1368772

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
milestone: none → kilo-2
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.