juju-core

Some third party embedded sources in the source tarball are missing dependencies.tsv entries

Bug #1368321 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Ian Booth
juju-core 1.21-alpha2
1.20
Fix Released
High
Ian Booth
juju-core 1.20.8

Bug Description

src/github.com/kisielk/gotool doesn't have an entry in dependencies.tsv. mgz suggests that it's a second level dependency, but I presume this should have a frozen commit ID too?

src/launchpad.net/goyaml doesn't have an entry either, but is a duplicate since src/gopkg.in/yaml.v1 does have one.

Tags: tech-debt
Revision history for this message
Robie Basak (racb) wrote :

(this is from juju-core_1.20.7.tar.gz)

Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Triaged
importance: Undecided → High
milestone: none → 1.21-alpha2
Curtis Hovey (sinzui)
Changed in juju-core:
assignee: nobody → Martin Packman (gz)
Revision history for this message
Curtis Hovey (sinzui) wrote :

Threre are two causes for this issue.

1 src/github.com/kisielk/gotool is a dep of a dep. We absolutely want this listed in dependencies .tsv
2. src/launchpad.net/goyaml is vestigial code, possibly caused by a merge error.

See bug 1368417 which suggests how to prevent this from happening again. At least ensuring a release cannot contain this ambiguity.

Revision history for this message
Ian Booth (wallyworld) wrote :

This package:

src/github.com/kisielk/gotool

is used to build the godeps tool which we use during development to maintain the dependnecies.tsv file.

It is not shipped as part of the product, and therefore does not need to be in the juju-core dependnecies.tsv file.

Ian Booth (wallyworld)
Changed in juju-core:
assignee: Martin Packman (gz) → Ian Booth (wallyworld)
status: Triaged → In Progress
Ian Booth (wallyworld)
Changed in juju-core:
status: In Progress → Fix Committed
Revision history for this message
Martin Packman (gz) wrote :

The juju/charm package is still pulling in the old yaml location in 1.20, I'm fixing that in:

<https://github.com/juju/charm/pull/48>

Revision history for this message
Martin Packman (gz) wrote :

Also the deps of deps on trunk:

<http://reviews.vapour.ws/r/78/>

John George (jog)
tags: added: tech-debt
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.