Extract Assignment related tests from IdentityTestCase

Bug #1367778 reported by Samuel de Medeiros Queiroz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Samuel de Medeiros Queiroz

Bug Description

IdentityTestCase is intended to have only tests for user and groups.
However it also has tests for domains, projects, roles and grants/role assignments.

Every test that are not for users or groups have to be extracted from IdentityTestCase (test_v3_identity) and to be put in AssignmentTestCase (test_v3_assignment, to be created).

Changed in keystone:
assignee: nobody → Samuel de Medeiros Queiroz (samuel-z)
Revision history for this message
Dolph Mathews (dolph) wrote :

+1 this probably should have been done during havana development, when the "assignment" backend was split out of "identity." So, there's some logic (historically) to how the tests are structured, but they should be refactored to reflect the modern division between identity and assignment.

tags: added: test-improvement
Changed in keystone:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Samuel, I have a couple test cases that are up for review that will have to be a part of this refactor. Since we are close to RC1, I held back on the refactor until development opens for Kilo. So far, I've been tagging tests in test_v3_identity.py with:

# TODO(lbragstad): Move this test to tests/test_v3_assignment.py

https://review.openstack.org/#/c/119843/5/keystone/tests/test_v3_identity.py

Revision history for this message
Samuel de Medeiros Queiroz (samueldmq) wrote :

Lance, thank you for this info. I'm gonna take yours tests and put them on test_v3_assignment if your patch get merged first.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121653

Changed in keystone:
status: Triaged → In Progress
Changed in keystone:
assignee: Samuel de Medeiros Queiroz (samuel-z) → Lance Bragstad (lbragstad)
Changed in keystone:
assignee: Lance Bragstad (lbragstad) → Samuel de Medeiros Queiroz (samuel-z)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/121653
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=87d14849512bc890514827923db3ed323b1b4071
Submitter: Jenkins
Branch: master

commit 87d14849512bc890514827923db3ed323b1b4071
Author: Samuel de Medeiros Queiroz <email address hidden>
Date: Mon Sep 15 15:38:18 2014 -0300

    Extract Assignment tests from IdentityTestCase

    Extracts tests for domains, projects, roles and
    grants/role assignments from IdentityTestCase
    and put them in AssignmentTestCase.

    Change-Id: I0e426fa1803e144b1c7a3eb503b212c6469e67c4
    Closes-Bug: 1367778

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (feature/hierarchical-multitenancy)

Fix proposed to branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (feature/hierarchical-multitenancy)

Change abandoned by Morgan Fainberg (<email address hidden>) on branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.