ceilometer API unable to handle mal-formed JSON for query alarms

Bug #1366215 reported by Srinivas Sakhamuri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Srinivas Sakhamuri

Bug Description

When tried with

ceilometer query-alarm-history -f <invalid or wrong schema json> causes a 500 error to be thrown, expect to get a 400 with reason for failure.

Changed in ceilometer:
assignee: nobody → Srinivas Sakhamuri (srinivas-sakhamuri)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120150

Changed in ceilometer:
status: New → In Progress
Changed in ceilometer:
importance: Undecided → Medium
Changed in ceilometer:
milestone: none → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/120150
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=4b26a9ab10ba563947d632447e8b29dd2f6aab91
Submitter: Jenkins
Branch: master

commit 4b26a9ab10ba563947d632447e8b29dd2f6aab91
Author: srsakhamuri <email address hidden>
Date: Tue Sep 9 16:45:40 2014 +0000

    Handle invalid JSON filters from the input gracefully

    When there is a invalid JSON string on the input for e.g. query-alarm-history
    at present the exception raised is un-caught causing a internal error
    with a HTTP error 500 returned to the client. This fix will handle those
    errors and return 400 error with proper message indicating the failure.

    Change-Id: Icd81a88f2c29a8baf7993325bf423435f1ad0924
    Closes-Bug: 1366215

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.