Use plural forms where appropriate
Bug #1363401 reported by
Данило Шеган
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Calendar App |
Fix Released
|
Low
|
Renato Araujo Oliveira Filho | ||
| Ubuntu Translations |
Triaged
|
High
|
Unassigned | ||
Bug Description
Following messages in ../AllDayEventC
"%1 Ev." (debatable because of length duration, but can't hurt)
"%1 All day events"
Note that plural forms are required even if you know that there will be more than one, since languages like Serbian use the noun form depending on the last digit of the number (eg. twenty-one will use the same form as one).
Related branches
lp://staging/~renatofilho/ubuntu-calendar-app/optimize
- Jenkins Bot: Approve (continuous-integration)
- Ubuntu Phone Apps Jenkins Bot: Pending (continuous-integration) requested
- Kunal Parmar: Pending requested
-
Diff: 6303 lines (+3052/-1463)33 files modifiedAgendaView.qml (+14/-13)
AllDayEventComponent.qml (+71/-36)
ContactChoicePopup.qml (+57/-15)
DayView.qml (+127/-87)
EventActions.qml (+2/-13)
EventBubble.qml (+61/-71)
EventLayoutHelper.js (+0/-132)
EventListModel.qml (+17/-5)
KeyboardRectangle.qml (+1/-7)
MonthComponent.qml (+178/-125)
MonthComponentDateDelegate.qml (+1/-140)
MonthComponentWithEventsDateDelegate.qml (+80/-0)
MonthView.qml (+46/-82)
MonthWithEventsComponent.qml (+80/-0)
NewEvent.qml (+228/-131)
NewEventBottomEdge.qml (+115/-0)
PageWithBottomEdge.qml (+44/-0)
PathViewBase.qml (+12/-4)
TimeLineBase.qml (+276/-190)
TimeLineBaseComponent.qml (+159/-75)
TimeLineHeader.qml (+6/-0)
WeekView.qml (+130/-60)
YearView.qml (+64/-48)
YearViewDelegate.qml (+39/-74)
calendar.qml (+150/-27)
calendar_canvas.js (+52/-0)
calendar_canvas_worker.js (+111/-0)
click/calendar-helper-apparmor.json (+1/-1)
click/calendar.apparmor (+1/-1)
click/manifest.json.in (+1/-1)
dateExt.js (+15/-2)
po/com.ubuntu.calendar.pot (+241/-123)
tests/unittests/tst_calendar_canvas.qml (+672/-0)
| Changed in ubuntu-translations: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: touch |
| Changed in ubuntu-calendar-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| milestone: | none → rtm14 |
| Changed in ubuntu-calendar-app: | |
| milestone: | rtm14 → 0.5 |
| Changed in ubuntu-calendar-app: | |
| status: | Confirmed → Fix Committed |
| assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
Revision history for this message
| Данило Шеган (danilo) wrote | #1 |
| Changed in ubuntu-calendar-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks for fixing this! Do note that now that the message is a full "%1 event"/"%1 events", the comment for translators is not really relevant anymore:
196 + // TRANSLATORS: the first parameter refers to the number of all-day events
197 + // on a given day. "Ev." is short form for "Events".
198 + // Please keep the translation of "Ev." to 3 characters only, as the week view
199 + // where it's shown has limited space
200 + return i18n.tr("%1 event", "%1 events", events.
FWIW, from a translation POV, it is fine to keep the short form, it's just that it needs to use plural forms (eg. i18n.tr("%1 Ev.", "%1 Ev.", events.length) is good enough if you need it to remain short text).