OpenStack Compute (nova)

_rescan_multipath construct wrong parameter for "multipath -r"

Bug #1362916 reported by Shen Wang
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Liyingjun
OpenStack Compute (nova) 2014.2 "juno"
Icehouse
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2014.1.4

Bug Description

At https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume.py#L590, the purpose of "self._run_multipath('-r', check_exit_code=[0, 1, 21]") is to setup a command to reconstruct multipath devices.
But the result of it is "multipath - r", not the right format "multipath -r".

I think brackets is missed for '-r', it should be modified to "self._run_multipath(['-r'], check_exit_code=[0, 1, 21])"

Tags: libvirt volume
Liyingjun (liyingjun)
Changed in nova:
status: New → Confirmed
assignee: nobody → Liyingjun (liyingjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118581

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/118581
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=51f3eb66ef498500df4af2faa7b7eb8fb3a5f438
Submitter: Jenkins
Branch: master

commit 51f3eb66ef498500df4af2faa7b7eb8fb3a5f438
Author: liyingjun <email address hidden>
Date: Fri Aug 8 15:54:17 2014 +0800

    Fix wrong command for _rescan_multipath

    The _run_multipath command is wrong in [1], it should be 'multipath -r'
    not 'multipath - r'. And adds test for this.

    [1]: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume.py#L590

    Change-Id: I3c5d12cc11988d65a8fc9e6143d26c2d1220d253
    Closes-bug: 1362916

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
Lee Yarwood (lyarwood)
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/138735

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/icehouse)

Reviewed: https://review.openstack.org/138735
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ac9f5c7d8bd47b7d87a85e853fe2e9340d1ab456
Submitter: Jenkins
Branch: stable/icehouse

commit ac9f5c7d8bd47b7d87a85e853fe2e9340d1ab456
Author: liyingjun <email address hidden>
Date: Fri Aug 8 15:54:17 2014 +0800

    Fix wrong command for _rescan_multipath

    The _run_multipath command is wrong in [1], it should be 'multipath -r'
    not 'multipath - r'. And adds test for this.

    [1]: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume.py#L590

    Change-Id: I3c5d12cc11988d65a8fc9e6143d26c2d1220d253
    Closes-bug: 1362916
    (cherry picked from commit 51f3eb66ef498500df4af2faa7b7eb8fb3a5f438)

tags: added: in-stable-icehouse
Alan Pevec (apevec)
summary: - _rescan_multipath construct wrong parameter for “multipath -r”
+ _rescan_multipath construct wrong parameter for "multipath -r"
Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.