Versionbump script needs to deal with setup.cfg version stamp

Bug #1358455 reported by John Wood
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
High
John Wood

Bug Description

The versionbump script used to supply a monotonically increasing version for rpm packages was modified to supply a 'version=' attribute to setup.cfg, to override the pbr-generated version. Unfortunately, this change breaks devstack deployments. So the version attribute was added back to setup.cfg. Now versionbump functionality needs to be reverted back to adding the timestamp to the hard-coded version stamp, but with the more Pythonic mods suggested in the previous CR.

John Wood (john-wood-w)
Changed in barbican:
assignee: nobody → John Wood (john-wood-w)
Changed in barbican:
milestone: none → juno-3
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/115149

Changed in barbican:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/115149
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=f53e0137cb2011fb1098e0dc588666894c1f60c0
Submitter: Jenkins
Branch: master

commit f53e0137cb2011fb1098e0dc588666894c1f60c0
Author: jfwood <email address hidden>
Date: Mon Aug 18 16:42:25 2014 -0500

    Update versionbuild script to handle setup.cfg version

    The versionbump script used to supply a monotonically increasing version for
    rpm packages was modified to supply a 'version=' attribute to setup.cfg, to
    override the pbr-generated version. Unfortunately, this change breaks devstack
    deployments. So the version attribute was added back to setup.cfg. Now
    versionbump functionality needs to be reverted back to adding the timestamp to
    the hard-coded version stamp, but with the more Pythonic mods suggested in the
    previous CR.

    Closes-Bug: #1358455
    Change-Id: Icc5a6a4319ea4517f2812168f25840253eb50e28

Changed in barbican:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in barbican:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.