Murano

[Dashboard] Gather and compress js/css static files.

Bug #1358233 reported by Ekaterina Chernova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Kirill Zaitsev
Murano 1.0.1

Bug Description

Currently js/css files are scattered across the project.

Horizon-way would be to:
1) create a 'murano-base.html' template, that extends 'base.html' from horizon (or whatever name is ok)
2) gather all the js files under 'custom_js_files' block in that file (don't forget super())
3) do the same with css (if we want to) under 'css' block (don't forget super())
4) change all files in murano-dashboard that extend base.html to extend murano-base.html

See original description
Tags: dashboard
Ekaterina Chernova (efedorova)
Changed in murano:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Ekaterina Chernova (efedorova)
milestone: none → juno-3
Serg Melikyan (smelikyan)
Changed in murano:
importance: Medium → High
ruhe (ruhe)
Changed in murano:
milestone: juno-3 → juno-rc1
Serg Melikyan (smelikyan)
Changed in murano:
milestone: juno-rc1 → none
Serg Melikyan (smelikyan)
Changed in murano:
importance: High → Medium
Ekaterina Chernova (efedorova)
Changed in murano:
milestone: none → kilo-rc1
assignee: Ekaterina Chernova (efedorova) → nobody
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

1) It's better to never compress images, btw

summary: - [Dashboard] All murano medial files are not compressed
+ [Dashboard] All murano media files are not compressed
description: updated
Serg Melikyan (smelikyan)
Changed in murano:
importance: Medium → Low
importance: Low → Medium
Kirill Zaitsev (kzaitsev)
summary: - [Dashboard] All murano media files are not compressed
+ [Dashboard] Gather and compress js/css static files.
Kirill Zaitsev (kzaitsev)
description: updated
Changed in murano:
milestone: kilo-rc1 → liberty-1
Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-1 → liberty-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/200764

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

This can probably be done with the new auto discovery tools, introduced in Liberty

tags: added: dashboard
Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-2 → liberty-3
Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-3 → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/200764
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=463ca4654c85261253e14fddcb4d5006808939a0
Submitter: Jenkins
Branch: master

commit 463ca4654c85261253e14fddcb4d5006808939a0
Author: Kirill Zaitsev <email address hidden>
Date: Sat Jul 11 02:28:56 2015 +0300

    Compress murano-dashboard related js in a single file

    this commit introduces 'murano_base.html' as the base template for all
    murano-dashboard templates. This commit contains js block, that contains
    and compresses all of the murano-dashboard js code. All js are moved
    from individual pages to murano_base.html. This means, that
    murano-dashboard js code has to behave nice, when put on a page, not
    designed for it and should not assume, that certain elements are present
    in DOM tree.
    To achieve this the commit does the following:
    * makes selectors more specific for 'environments-in-place.js'
    * makes topology code only launch on tab init
    * makes import form code only launch on modal init

    Also moves modal init code to ADD_JS_FILES section, to allow calling
    murano modals from external dashboards (i.e. app-catalog-ui)

    Change-Id: I342702b6b236b3323f57a4a26fdf4120505b9800
    Partial-Bug: #1358233

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227291

Kirill Zaitsev (kzaitsev)
Changed in murano:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Kirill Zaitsev (kzaitsev)
Changed in murano:
status: In Progress → Fix Committed
Kirill Zaitsev (kzaitsev)
Changed in murano:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/227291
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=85765e8ddc119c8137b45d6ba5c768e4c8e9a2d5
Submitter: Jenkins
Branch: master

commit 85765e8ddc119c8137b45d6ba5c768e4c8e9a2d5
Author: Kirill Zaitsev <email address hidden>
Date: Thu Sep 24 17:22:20 2015 +0300

    Compress murano-dashboard css

    This commit gathers murano-related css files, into css section and
    compresses them for better space and performance.
    Removes no longer required css from modal forms.

    Change-Id: Iaeeec20bd9c6b89e46fb65f4da2e67038acef849
    Closes-Bug: #1358233

Changed in murano:
status: In Progress → Fix Committed
Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-rc1 → 1.0.0
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: 1.0.0 → 1.0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.