Ironic

Agent heartbeat thread sleeps with absolute time

Bug #1355375 reported by Jim Rollenhagen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Jim Rollenhagen
Ironic 2015.1.0 "kilo"

Bug Description

If the clock changes while the heartbeat thread is running, the heartbeat thread won't notice.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-python-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113343

Changed in ironic:
assignee: nobody → Jim Rollenhagen (jim-rollenhagen)
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/113343
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=4f57590b2e41863770b764a8b84b8b81830ad577
Submitter: Jenkins
Branch: master

commit 4f57590b2e41863770b764a8b84b8b81830ad577
Author: Jim Rollenhagen <email address hidden>
Date: Mon Aug 11 11:45:28 2014 -0700

    Use poll instead of threading.Event in heartbeat thread

    poll() does not rely on absolute time.
    This fixes an issue where the system clock may be changed, and
    the heartbeat thread would stop heartbeating.

    This also gives us flexibility to force a heartbeat in a later
    change.

    Change-Id: Ifde7b53f59788addc43a5dac95c7b6519d87e834
    Closes-Bug: 1355375

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.