get_make_and_model job script needs error handling
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Provider - Base |
Fix Released
|
High
|
Jeff Lane |
Bug Description
The script for the get_make_and_model test needs some error handling:
Traceback (most recent call last):
File "/tmp/nest-
raise SystemExit(main())
File "/tmp/nest-
print_
File "/tmp/nest-
with open(filename) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/sys/class/
This is the result when run on an ARM system that has no DMI.
Solution: add error handling so that the test gets data from somewhere else on ARM systems, or just does not run on ARM if this data is not retrievable.
Related branches
- Daniel Manrique (community): Approve
- Jeff Lane : Needs Resubmitting
-
Diff: 59 lines (+26/-9)2 files modifiedproviders/plainbox-provider-checkbox/bin/get_make_and_model (+25/-8)
providers/plainbox-provider-checkbox/jobs/miscellanea.txt.in (+1/-1)
affects: | checkbox → plainbox-provider-checkbox |
Changed in plainbox-provider-checkbox: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → future |
Changed in plainbox-provider-checkbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
milestone: | future → 0.12 |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |
slightly more complicated... error handling and some revising of the innards is done... but now I need to look into device-tree to add support for the device-tree analogs to the /sys/class/dmi files we use on x86 systems.