Mir

[enhancement] It should be possible to customize configuration options without going via boost options and the commandline

Bug #1351255 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Wishlist
Alan Griffiths
0.6
Fix Released
Wishlist
Alan Griffiths
Mir 0.6.0
mir (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Shells will typically want to handle their own command line and pass some options to Mir and not need to provide Mir with a command line to parse. (Unity8 would want to use QCommandLineParser for example.)

There is some separation into the mir::options but there's no effective support for building a replacement for DefaultConfiguration on top of another parsing technology.

Tags: enhancement

Related branches

lp://staging/~alan-griffiths/mir/command-line-handling
PS Jenkins bot (community): Approve (continuous-integration)
Alan Griffiths: Abstain
Robert Carr (community): Approve
Alexandros Frantzis (community): Approve
Diff: 290 lines (+167/-6)
9 files modified
include/platform/mir/options/default_configuration.h (+5/-0)
include/platform/mir/options/program_option.h (+3/-0)
server-ABI-sha1sums (+2/-2)
src/platform/options/default_configuration.cpp (+27/-0)
src/platform/options/program_option.cpp (+9/-2)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_command_line_handling.cpp (+96/-0)
tests/acceptance-tests/test_nested_mir.cpp (+2/-2)
tests/unit-tests/options/test_program_option.cpp (+22/-0)
lp://staging/mir/0.6
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Kevin DuBois (community): Needs Information
Alberto Aguirre (community): Approve
Diff: 1037 lines (+536/-184)
19 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+11/-0)
debian/control (+4/-4)
include/test/mir_test_framework/using_stub_client_platform.h (+11/-3)
src/client/api_impl.h (+0/-27)
src/client/api_impl_types.h (+0/-32)
src/client/mir_connection_api.cpp (+73/-66)
src/client/mir_connection_api.h (+59/-0)
src/platform/graphics/android/hwc_device.cpp (+19/-3)
src/platform/graphics/android/hwc_device.h (+1/-0)
src/platform/graphics/android/hwc_logger.h (+5/-0)
src/platform/graphics/android/hwc_loggers.cpp (+36/-0)
src/platform/graphics/android/hwc_loggers.h (+8/-0)
src/platform/graphics/android/real_hwc_wrapper.cpp (+4/-0)
tests/mir_test_framework/server_runner.cpp (+1/-1)
tests/mir_test_framework/using_stub_client_platform.cpp (+37/-35)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+190/-0)
tests/unit-tests/graphics/android/test_hwc_logger.cpp (+40/-0)
tests/unit-tests/graphics/android/test_hwc_wrapper.cpp (+36/-12)
lp://staging/ubuntu/utopic-proposed/mir
Revision history for this message
Gerry Boland (gerboland) wrote :

Agreed. We would very much like that we can combine Qt's and Mir's command line parsing and help output in a way that makes sense.

If Mir could offer a method which we pass command line arguments, and it returns a command line argument list with the mir recognised entries removed, it would help a lot.

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Gerry, I was thinking of a very different approach:

That there could be a way to programmatically determine the options Mir supports (and their corresponding defaults) and that clients should be able to build an Options object using their own parsing of command-line, environment and/or config files.

It would certainly be simpler to focus on the command-line only and allow that to be "partitioned".

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: New → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.7.0
Cemil Azizoglu (cemil-azizoglu)
Changed in mir:
milestone: 0.7.0 → 0.6.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix backported to lp:mir/0.6 at revision 1834.

Changed in mir:
milestone: 0.6.0 → 0.7.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

mir (0.6.0+14.10.20140811-0ubuntu1) utopic; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → Wishlist
status: New → Fix Released
Cemil Azizoglu (cemil-azizoglu)
Changed in mir:
milestone: 0.7.0 → none
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.7.0
status: Fix Released → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sorry for the confusion. Most of the 0.7.0 series got merged into 0.6.0 at a late stage. I've verified everything in 0.6.0 is also fixed in 0.7.0. So although the branched fixes in 0.7.0 have not been "released" yet, the equivalent fixes in 0.6.0 have. No need to mention them in 0.7 any more.

Changed in mir:
milestone: 0.7.0 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.