OpenStack Shared File Systems Service (Manila)

manila has modules that are not covered with unittests

Bug #1348635 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Marc Koderer
OpenStack Shared File Systems Service (Manila) 2015.1.0 "kilo"

Bug Description

All project modules should be covered with unittests.

Examples of not covered modules:
manila/share/driver.py
manila/share/manager.py
...

Valeriy Ponomaryov (vponomaryov)
Changed in manila:
importance: Undecided → High
summary: - module manila.share.manager not covered with unittests
+ manila has modules that is not covered with unittests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/109644
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=61316b7adb37cbbcfec0be8cbfca3274b6c19b24
Submitter: Jenkins
Branch: master

commit 61316b7adb37cbbcfec0be8cbfca3274b6c19b24
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Jul 25 12:06:00 2014 -0400

    Remove reference to 'in-use' state in share manager

    State 'in-use' is leftover from Cinder and is not used by shares,
    hence it should be removed.
    Due to absense of tests for this module at all, as part of bug fix
    were added unittests.

    Change-Id: I768d731bac3eb1f420695082e69598e55e1de90b
    Closes-Bug: #1346371
    Partial-Bug: #1348635

Ben Swartzlander (bswartz)
Changed in manila:
milestone: none → kilo-1
Marc Koderer (m-koderer)
Changed in manila:
assignee: nobody → Marc Koderer (m-koderer)
Ben Swartzlander (bswartz)
Changed in manila:
milestone: kilo-1 → kilo-2
Valeriy Ponomaryov (vponomaryov)
summary: - manila has modules that is not covered with unittests
+ manila has modules that are not covered with unittests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/149238

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/150343

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/150343
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4dcac488b324f9a83e42cbb6447c3f03746676ec
Submitter: Jenkins
Branch: master

commit 4dcac488b324f9a83e42cbb6447c3f03746676ec
Author: Marc Koderer <email address hidden>
Date: Tue Jan 27 11:13:22 2015 +0100

    Add unit test for quota remains functionality

    get_project_quotas support a "remain" parameter to add the remaining
    space into the returned data structure. This will be tested by the
    introduced test.

    Change-Id: I612d58365d2b584b0a93ffd65d91cd26839420f6
    Partial-Bug: #1348635

Valeriy Ponomaryov (vponomaryov)
Changed in manila:
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/149238
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=79e2c102199244f635a2be721220cca899954d0b
Submitter: Jenkins
Branch: master

commit 79e2c102199244f635a2be721220cca899954d0b
Author: Marc Koderer <email address hidden>
Date: Thu Jan 22 13:45:56 2015 +0100

    Add unit test for volume types

    Adds multiple test cases for volume types:

     - get_all_volumes_types
     - volume_type_extra_specs
     - volume_types_diff

    Change-Id: I15ac1ca7af7ffe24c606ec0484fcaad35fdc1334
    Partial-Bug: #1348635

Ben Swartzlander (bswartz)
Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.