aggregator transformer broken

Bug #1342664 reported by Nejc Saje
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Nejc Saje

Bug Description

- it is parsing the sample's timestamp with parse_strtime instead of parse_isotime
- if the retention_time is specified as a string, it fails with unintuitive error messages

Nejc Saje (nejc-saje)
Changed in ceilometer:
assignee: nobody → Nejc Saje (nejc-saje)
Revision history for this message
Ala Rezmerita (arezmerita) wrote :

Hi,
There is already a patch in review for empty project, user id : https://review.openstack.org/#/c/101913/
and a patch for fixing aggregator flush method: https://review.openstack.org/#/c/97176/

Revision history for this message
Nejc Saje (nejc-saje) wrote :

Great! Removing that from the description then :-)

description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/107347

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/107347
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=2a0f1e87891ea334358cb46c6b16d2f99cf0aee3
Submitter: Jenkins
Branch: master

commit 2a0f1e87891ea334358cb46c6b16d2f99cf0aee3
Author: Nejc Saje <email address hidden>
Date: Wed Jul 16 14:09:02 2014 +0200

    Fixes aggregator transformer timestamp and user input handling

    Sample timestamps should be parsed with parse_isotime(), not
    parse_strtime().

    User input should be validated and fail with ValueError if wrong.

    Closes-bug: #1342664
    Change-Id: Ied429053eecfa355c1e73caae705e5b187c8b3aa

Changed in ceilometer:
status: In Progress → Fix Committed
Eoghan Glynn (eglynn)
Changed in ceilometer:
importance: Undecided → Medium
milestone: none → juno-2
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.