mir_unit_tests: XCursorLoader.loads_cursors_from_testing_theme crashes on N4
Bug #1342029 reported by
Daniel van Vugt
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Kevin DuBois | ||
| mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
mir_unit_tests: XCursorLoader.
umockdev-run -- bin/mir_unit_tests --gtest_
Running main() from command_
Note: Google Test filter = XCursorLoader*
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from XCursorLoader
[ RUN ] XCursorLoader.
Segmentation fault (core dumped)
Related branches
lp://staging/~kdub/mir/fix-1342029
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Approve
- Alexandros Frantzis (community): Approve
-
Diff: 417 lines (+106/-42)20 files modifiedinclude/test/mir_test_framework/executable_path.h (+28/-0)
include/test/mir_test_framework/udev_environment.h (+0/-3)
src/server/input/xcursor_loader.cpp (+2/-1)
tests/mir_test_framework/CMakeLists.txt (+6/-0)
tests/mir_test_framework/executable_path.cpp (+40/-0)
tests/mir_test_framework/udev_environment.cpp (+3/-19)
tests/unit-tests/CMakeLists.txt (+0/-1)
tests/unit-tests/android_input/test_eventhub.cpp (+3/-3)
tests/unit-tests/graphics/mesa/test_buffer_allocator.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_display.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_display_buffer.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_display_configuration.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_drm_helper.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_gbm_buffer.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_platform.cpp (+1/-1)
tests/unit-tests/graphics/test_display.cpp (+1/-1)
tests/unit-tests/graphics/test_graphics_platform.cpp (+1/-1)
tests/unit-tests/input/test_xcursor_loader.cpp (+13/-4)
tests/unit-tests/test_udev_wrapper.cpp (+1/-1)
| tags: | added: cursor |
| Changed in mir: | |
| assignee: | nobody → Kevin DuBois (kdub) |
| status: | New → In Progress |
| milestone: | none → 0.6.0 |
| importance: | Undecided → Medium |
Revision history for this message
| Kevin DuBois (kdub) wrote | #1 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #2 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #3 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Fix Released |
To post a comment you must log in.
So what is happening is we have a hardcoded path to the cursor images that is based on the directory that the code was compiled in. Installing to this specific directory is not accommodated for in the deploy-and-test.sh script. When the cursor images fail to load (because the directory is not present), the test will then segfault.
Changing the test to 1) find the cursor images from its current working directory (much like the udev recordings), and 2) fail instead of segfault if it cannot find the images.