Fuel for OpenStack

[library] fuel-library puppet-lint tests stop on first failure

Bug #1340336 reported by Andrew Woodward
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Aleksandr Didenko
Fuel for OpenStack 6.0-updates
5.1.x
Won't Fix
High
Aleksandr Didenko
Fuel for OpenStack 5.1.1-updates
6.0.x
Won't Fix
High
Aleksandr Didenko
Fuel for OpenStack 6.0-updates
6.1.x
Fix Released
High
Aleksandr Didenko
Fuel for OpenStack 6.1

Bug Description

The puppet-lint tests from fuel-library/utils/jenkins/fuel_syntax_check.sh stops on the first failure instead of collecting all issues. This can lead to increased load on the CI infra as it requires more revisions to find all errors if not run locally.

Dmitry Ilyin (idv1985)
summary: - fuel-library puppet-lint tests stop on first failure
+ [QA] fuel-library puppet-lint tests stop on first failure
Igor Shishkin (teran)
summary: - [QA] fuel-library puppet-lint tests stop on first failure
+ [devops] fuel-library puppet-lint tests stop on first failure
Igor Shishkin (teran)
Changed in fuel:
assignee: Fuel DevOps (fuel-devops) → Fuel Library Team (fuel-library)
summary: - [devops] fuel-library puppet-lint tests stop on first failure
+ [library] fuel-library puppet-lint tests stop on first failure
Revision history for this message
Aleksandra Fedorova (bookwar) wrote :

I've removed '-e' from

/bin/bash -e $WORKSPACE/utils/jenkins/fuel_syntax_check.sh

command

Changed in fuel:
status: Confirmed → Fix Committed
Revision history for this message
Aleksandra Fedorova (bookwar) wrote :

Seems to be reverted by https://bugs.launchpad.net/fuel/+bug/1367506

Changed in fuel:
status: Fix Committed → Confirmed
status: Confirmed → Fix Committed
Aleksandr Didenko (adidenko)
Changed in fuel:
status: Fix Committed → In Progress
assignee: Fuel Library Team (fuel-library) → Aleksandr Didenko (adidenko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/139090

Revision history for this message
Mike Scherbakov (mihgen) wrote :

Moved to 6.1, as it is devops/CI issue and does not block 6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/139090
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=47bf38d6803b659b79b4c3bd942fa569ee3ebfa2
Submitter: Jenkins
Branch: master

commit 47bf38d6803b659b79b4c3bd942fa569ee3ebfa2
Author: Aleksandr Didenko <email address hidden>
Date: Thu Dec 4 14:48:20 2014 +0200

    Refactor fuel syntax check script

    - Check syntax for changed modules only
    - Use 'rake lint' instead of 'puppet-lint' where possible
    - Use 'bundle' for rake lint tests
    - Fix current syntax errors that break 'rake lint' or disable
      'fail_on_warnings' option for lint

    Closes-bug: #1340336
    Change-Id: I66c5b4799dafc32e7903c16365a277109cfb6723

Changed in fuel:
status: Triaged → Fix Committed
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

@Aleksandr, please update the status of your work in progress for 6.1 release and the status for 5.1?

Revision history for this message
Aleksandr Didenko (adidenko) wrote :

We won't use new syntax check for previous release since otherwise we'd have to fix all the linting errors for 6.0 and 5.1 which new test script will find. So it's released for 6.1 and "won't fix" for the others.

Dennis Dmitriev (ddmitriev)
tags: added: system-test-not-required
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.