coreos-oem-inject.py uses non-approved requirements and is not pep8-compliant
Bug #1337551 reported by
Jay Faulkner
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ironic |
Fix Released
|
Medium
|
Jim Rollenhagen | ||
Bug Description
The current script used to inject the IPA container into CoreOS is not pep8 compliant, has requirements that are not in global-
We should:
- Remove the requirement on plumbum
- Make the script pep8 compliant
- Ensure lint runs against the script when tests are run (even thought there are no unit tests for this script)
| Changed in ironic: | |
| assignee: | nobody → Kyle Stevenson (m-kyle) |
Revision history for this message
| Dmitry Tantsur (divius) wrote Re: coreos-oem.inject.py uses non-approved requirements and is not pep8-compliant | #1 |
| summary: |
- imagebuild/coreos/coreos-oem.inject.py uses non-approved requirements - (plumbum) + coreos-oem.inject.py uses non-approved requirements and is not + pep8-compliant |
| Changed in ironic: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
Revision history for this message
| Kyle Stevenson (kylestev) wrote | #2 |
| Changed in ironic: | |
| assignee: | Kyle Stevenson (kylestev) → nobody |
| summary: |
- coreos-oem.inject.py uses non-approved requirements and is not + coreos-oem-inject.py uses non-approved requirements and is not pep8-compliant |
| Changed in ironic: | |
| assignee: | nobody → Vladyslav Drok (vdrok) |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to ironic-python-agent (master) | #3 |
| Changed in ironic: | |
| status: | Triaged → In Progress |
| Changed in ironic: | |
| assignee: | Vladyslav Drok (vdrok) → Jim Rollenhagen (jim-rollenhagen) |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to ironic-python-agent (master) | #4 |
| Changed in ironic: | |
| status: | In Progress → Fix Committed |
| Changed in ironic: | |
| milestone: | none → kilo-1 |
| status: | Fix Committed → Fix Released |
| Changed in ironic: | |
| milestone: | kilo-1 → 2015.1.0 |
To post a comment you must log in.
Hi Kyle! You've been assigned to this bug for nearly 2 weeks and we have policy of not keeping a bug assigned without a patch for >7 days. What's your status on it?