pecan

RestController should return HTTP 405

Bug #1334690 reported by Ryan Petrello
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Chris Dent
Ceilometer 5.0.0 "liberty"
Designate
Fix Released
High
Ryan Petrello
Designate 1.0.0 "liberty"
pecan
Fix Released
Medium
Ryan Petrello

Bug Description

RestController has a variety of branches which return HTTP 404 (and some that correctly return 405). Audit the code and properly return HTTP 405 in situations where a specified method is not supported (instead of an HTTP 404). Additionally, update RestController to properly return an "Allow:" header so that API consumers know which request methods are allowed.

Ryan Petrello (ryan-petrello)
Changed in pecan:
importance: Undecided → Medium
status: New → Confirmed
Ryan Petrello (ryan-petrello)
Changed in pecan:
assignee: nobody → Ryan Petrello (ryan-petrello)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/182273

Changed in designate:
assignee: nobody → Ryan Petrello (ryan-petrello)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in designate:
assignee: Ryan Petrello (ryan-petrello) → Kiall Mac Innes (kiall)
Graham Hayes (grahamhayes)
Changed in designate:
milestone: none → liberty-1
importance: Undecided → High
Kiall Mac Innes (kiall)
Changed in designate:
assignee: Kiall Mac Innes (kiall) → Ryan Petrello (ryan-petrello)
OpenStack Infra (hudson-openstack)
Changed in pecan:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/182273
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=35b6d607e130a8c2b5db3553e52cf71d93bded2c
Submitter: Jenkins
Branch: master

commit 35b6d607e130a8c2b5db3553e52cf71d93bded2c
Author: Ryan Petrello <email address hidden>
Date: Tue May 12 08:50:50 2015 -0400

    Remove unnecessary RestController usage

    TasksControllers is just an intermediate path segment, and doesn't need to be
    a RestController. Additionally, this resolves a failing test associated with
    a RestController bug fix in pecan [1].

    [1] https://review.openstack.org/#/c/181979/
    Closes-Bug: #1334690

    Change-Id: I90b8f499f23762cbc6333be764439104189238b8

Changed in designate:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pecan (master)

Reviewed: https://review.openstack.org/181979
Committed: https://git.openstack.org/cgit/stackforge/pecan/commit/?id=3c634de56666cfadf19b813dd9de4e7e66b6ac65
Submitter: Jenkins
Branch: master

commit 3c634de56666cfadf19b813dd9de4e7e66b6ac65
Author: Ryan Petrello <email address hidden>
Date: Mon May 11 09:48:53 2015 -0700

    Properly raise HTTP 405 (and specify Allow headers) for RestController

    Change-Id: Id790efc75c8207eb61d74e9b2242b310ccd62ab1
    Depends-On: Ieffa3fddc3c8d3152742455ca46d69bcc7208d69
    Closes-bug: #1334690
    Closes-bug: #1450109

Changed in pecan:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/185684

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/kilo)

Reviewed: https://review.openstack.org/185684
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=c7b7975d877fc09462f4f761ed2527a0db1e062a
Submitter: Jenkins
Branch: stable/kilo

commit c7b7975d877fc09462f4f761ed2527a0db1e062a
Author: Ryan Petrello <email address hidden>
Date: Tue May 12 08:50:50 2015 -0400

    Remove unnecessary RestController usage

    TasksControllers is just an intermediate path segment, and doesn't need to be
    a RestController. Additionally, this resolves a failing test associated with
    a RestController bug fix in pecan [1].

    [1] https://review.openstack.org/#/c/181979/
    Closes-Bug: #1334690

    Change-Id: I90b8f499f23762cbc6333be764439104189238b8
    (cherry picked from commit 35b6d607e130a8c2b5db3553e52cf71d93bded2c)

tags: added: in-stable-kilo
Ryan Petrello (ryan-petrello)
Changed in pecan:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Revision history for this message
gordon chung (chungg) wrote :

addressed by:

https://review.openstack.org/#/c/182306/ and https://github.com/openstack/ceilometer/commit/4a0aceecaa2a8e516df33e82e4beae17a68b9f49

Changed in ceilometer:
status: New → Fix Committed
gordon chung (chungg)
Changed in ceilometer:
assignee: nobody → Chris Dent (chdent)
importance: Undecided → Medium
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-1 → 1.0.0
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.