python-neutronclient

fwaas:In firewall-rule-create cli --disabled should be removed

Bug #1327056 reported by Rajkumar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Low
Koteswara Rao Kelam
python-neutronclient 2.3.7

Bug Description

 In neutron firewall-rule-create cli --disabled should be removed. Though we can able to disable the firewall rule using this option, we cannot enable it again. However using --enabled True|False we can either enable or disable the firewall rule.
 And also --enable should be shown as optional arguments in help instead of --disable.

Revision history for this message
Shivakumar M (shiva-m) wrote :

Its better to provide CLI option --enable (True/False). --disabled is not required.

Changed in neutron:
assignee: nobody → Shivakumar M (shiva075gowda)
Eugene Nikanorov (enikanorov)
affects: neutron → python-neutronclient
Changed in python-neutronclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/103769

Changed in python-neutronclient:
assignee: Shivakumar M (shiva-m) → Koteswara Rao Kelam (koti-kelam)
status: New → In Progress
Kyle Mestery (mestery)
Changed in python-neutronclient:
milestone: none → 2.3.7
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/103769
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=6260c207fb7d089cc56e08f89fcb755c0086c733
Submitter: Jenkins
Branch: master

commit 6260c207fb7d089cc56e08f89fcb755c0086c733
Author: Koteswara Rao Kelam <email address hidden>
Date: Tue Jul 1 00:21:29 2014 -0700

    Remove "--disabled" for firewall create rule

    Allow "--enabled True/False" and remove "--disabled" for consistency across
    all commands. Even in other neutron commands, we are using only --enabled
    option but not --disabled. firewall-rule-show displays only "enabled" attribute
    and there is no "disabled" attribute.

    Change-Id: Ie591d827660466a774e431dcb40e04e09773e5f7
    Closes-bug: 1327056

Changed in python-neutronclient:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.