neutron

ML2: validate network configuration

Bug #1325664 reported by Manish Godara
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Manish Godara
neutron 2015.1.0 "kilo"

Bug Description

Validate that each physical_network name is neither empty nor too long. When a network is added we should make sure the physical_network name is appropriately configured (see comments in code plugins/ml2/drivers/type_flat.py as well type_vlan.py)

Tags: ml2
Manish Godara (manishatyhoo)
Changed in neutron:
assignee: nobody → Manish Godara (manishatyhoo)
Eugene Nikanorov (enikanorov)
tags: added: ml2
Changed in neutron:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102295

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/102295
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8f3301cb2792cf05dd29a79506719b0141bf029f
Submitter: Jenkins
Branch: master

commit 8f3301cb2792cf05dd29a79506719b0141bf029f
Author: Manish Godara <email address hidden>
Date: Tue Jun 24 10:23:59 2014 -0700

    validate flat networks physical name

    Modified flat driver to validate the physical network
    name - we make sure that empty names are deducted.

    unit test changes:
    - added two tests to make sure that we detect empty
      physnet names
    - fix bug in existing unit-tests
    -- flat_networks should be a list of string and not string
    - use conf to setup flat_network

    Change-Id: Ib7cfbd3c97d2e95c82044a2cba683c917ea54a84
    Partial-bug: #1325664

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/126360

Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/126360
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7d7776972117a6dc8697104117b8cec4d83f2c87
Submitter: Jenkins
Branch: master

commit 7d7776972117a6dc8697104117b8cec4d83f2c87
Author: Manish Godara <email address hidden>
Date: Mon Oct 6 10:03:28 2014 -0700

    Validate network config (vlan)

    Validate to make sure empty physical networks
    are not permitted. Added unit test as well.

    Change-Id: Ie55fab3c53276ed48d5e9d603e8c1dc59fa9cc32
    Closes-Bug: 1325664

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.