Sahara

[HDP] set_ambari_credentials__no_admin_user tests nothing

Bug #1325108 reported by Andrew Lazarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Invalid
Undecided
Unassigned

Bug Description

https://github.com/openstack/sahara/blob/stable/icehouse/sahara/tests/unit/plugins/hdp/test_ambariplugin.py#L238

test passes result of plugin._set_ambari_credentials execution to assertRaises, but not reference on method to execute. Note extra parentheses. The following patch fixes the issue:

         self.assertRaises(ex.HadoopProvisionError,
- plugin._set_ambari_credentials(cluster_spec,
- ambari_info, '1.3.2'))
+ plugin._set_ambari_credentials,
+ cluster_spec, ambari_info, '1.3.2')

But after that test fails. It looks that behavior of _set_ambari_credentials is incorrect. More deep understanding of HDP code is needed.

Revision history for this message
Sergey Lukjanov (slukjanov) wrote :

John, could you please confirm?

Changed in sahara:
assignee: nobody → John Speidel (jspeidel)
Michael McCune (mimccune)
Changed in sahara:
status: New → Incomplete
Revision history for this message
Sergey Lukjanov (slukjanov) wrote :

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in sahara:
assignee: John Speidel (jspeidel) → nobody
Revision history for this message
Vitalii Gridnev (vgridnev) wrote :

Module was removed. Moving to invalid

Changed in sahara:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.