Cinder

SolarisISCSIDriver fails on _execute

Bug #1318108 reported by Scott Devoid
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Scott Devoid
Cinder 2014.2 "juno"
Icehouse
Fix Released
High
Mike Perez
Cinder 2014.1.1

Bug Description

A previous refactor [1] of SolarisISCSIDriver and SanDriver renamed
the `_execute` function to `san_execute`. However, SolarisISCSIDriver
still called the _execute function, which no longer exists in it's
parent classes.

[1] https://review.openstack.org/#/c/38194/

Scott Devoid (scott-devoid)
Changed in cinder:
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: nobody → Scott Devoid (scott-devoid)
John Griffith (john-griffith)
tags: added: icehouse-backport-potential
Changed in cinder:
importance: Undecided → High
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/92214
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a7f24f0a2395594ead7eb8a5cef894b257cd7e4f
Submitter: Jenkins
Branch: master

commit a7f24f0a2395594ead7eb8a5cef894b257cd7e4f
Author: Scott Devoid <email address hidden>
Date: Mon May 5 16:44:44 2014 -0500

    Fix solaris_execute in SolarisISCSIDriver.

    A previous refactor [1] of SolarisISCSIDriver and SanDriver renamed
    the `_execute` function to `san_execute`. However, SolarisISCSIDriver
    still called the _execute function, which no longer exists in it's
    parent classes.

    This change calls san_execute instead of _execute in
    super(SolarisISCSIDriver, san).

    [1] https://review.openstack.org/#/c/38194/

    Closes-Bug: #1318108
    Change-Id: I4cafefdb3eef8f3c2c345907d7eabd4e8f88ef65

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/94099

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/icehouse)

Reviewed: https://review.openstack.org/94099
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bc585a00c6f96e7a4a9b2f50b7577192de41eb48
Submitter: Jenkins
Branch: stable/icehouse

commit bc585a00c6f96e7a4a9b2f50b7577192de41eb48
Author: Scott Devoid <email address hidden>
Date: Mon May 5 16:44:44 2014 -0500

    Fix solaris_execute in SolarisISCSIDriver.

    A previous refactor [1] of SolarisISCSIDriver and SanDriver renamed
    the `_execute` function to `san_execute`. However, SolarisISCSIDriver
    still called the _execute function, which no longer exists in it's
    parent classes.

    This change calls san_execute instead of _execute in
    super(SolarisISCSIDriver, san).

    [1] https://review.openstack.org/#/c/38194/

    Closes-Bug: #1318108
    Change-Id: I4cafefdb3eef8f3c2c345907d7eabd4e8f88ef65
    (cherry picked from commit a7f24f0a2395594ead7eb8a5cef894b257cd7e4f)

tags: added: in-stable-icehouse
Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.