central agent skips pollsters not requiring keystone when service creds are invalid

Bug #1316532 reported by Eoghan Glynn
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
High
Lianhao Lu

Bug Description

Since this patch landed:

  https://review.openstack.org/78079

the central agent now skips *all* pollsters when the configured service credentials are invalid, even though only a subset of the pollsters managed by this agent actually require keystone auth.

In particular the SNMP-based hardware pollsters do not require a keystone client, so should not be suppressed when the configured creds are incorrect.

Only the pollsters themselves know a priori if they need keystone, so the skipping logic should be driven from within the pollsters as opposed to the global agent level.

Eoghan Glynn (eglynn)
Changed in ceilometer:
assignee: nobody → Eoghan Glynn (eglynn)
milestone: none → juno-1
importance: Undecided → High
description: updated
Eoghan Glynn (eglynn)
Changed in ceilometer:
status: New → Triaged
Eoghan Glynn (eglynn)
Changed in ceilometer:
assignee: Eoghan Glynn (eglynn) → Lianhao Lu (lianhao-lu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98109

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/98109
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=5e5559b5450bf933d4aefcbd45abbcacac405e1b
Submitter: Jenkins
Branch: master

commit 5e5559b5450bf933d4aefcbd45abbcacac405e1b
Author: Lianhao Lu <email address hidden>
Date: Thu Jun 5 20:19:45 2014 +0800

    Skipping central agent pollster when keystone not available

    When keystone is not available, instead of skipping all central agent
    pollsters, we should let the pollsters decide whether to skip or not,
    because not all central agent pollsters requires keystone.

    Closes-Bug: #1316532

    Change-Id: Ib34f9838bd128e1b357937f0c177d8a09f19b13f

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.