Allow Header foreground color customization per Page
Bug #1315884 reported by
Michael Hall
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
High
|
Tim Peeters | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
Bug Description
Each Page should have the ability to customize a few things about the look of the header, these changes should take affect when the page becomes the top page in a PageStack or the current tab in Tabs.
headerTextColor: Set the color of text displayed in the Header
I removed the other (header background) properties from this bug, they are now in a separate bug here: https:/
Related branches
lp://staging/~tpeeters/ubuntu-ui-toolkit/headIconColor
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 299 lines (+125/-21)8 files modifiedcomponents.api (+1/-0)
examples/ubuntu-ui-toolkit-gallery/Icons.qml (+4/-6)
modules/Ubuntu/Components/Icon10.qml (+3/-1)
modules/Ubuntu/Components/PageHeadConfiguration.qml (+5/-0)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadButton.qml (+5/-6)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+6/-2)
tests/resources/header/header.qml (+5/-6)
tests/unit/tst_components/tst_header_colors.qml (+96/-0)
| tags: | added: android-compat header theming |
Revision history for this message
| Tim Peeters (tpeeters) wrote | #1 |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Confirmed |
| assignee: | nobody → Tim Peeters (tpeeters) |
| importance: | Undecided → Medium |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Medium → High |
Revision history for this message
| Tim Peeters (tpeeters) wrote | #2 |
Revision history for this message
| Tim Peeters (tpeeters) wrote | #3 |
| summary: |
- Allow Header style customization per Page + Allow Header foreground color customization per Page |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → In Progress |
| description: | updated |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #4 |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Timo Jyrinki (timo-jyrinki) wrote | #5 |
| Changed in ubuntu-ui-toolkit: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
Michael can you discuss with design which customization is important?
I do not think "android-compat" is a good enough motivation for implementing certain features. If you can add a few use cases, that would help in prioritizing the features and deciding on an API to add them (for example, for a fixed header color per-app we may recommend to use theming, or add a property to the MainView. However, if it is a common use case to change the header-color per Page in an app, we may need to add a property to the page. It is also important to get feedback from design on this to find out which settings we like to promote and for which we will recommend the app developers to use the defaults to make the applications consistent).