android platform does not reset the compositionType to HWC_FRAMEBUFFER before prepare() on every frame
Bug #1314399 reported by
Kevin DuBois
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Kevin DuBois | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
This came out in some of my testing where we transition from overlay to fallback rendering (and vice versa), but we should be resetting the:
hwc_layer_
field to HWC_FRAMEBUFFER before we call prepare(), because we always have HWC_GEOMETRY_
This isn't causing us any problems in unity/demo shells because they aren't using overlays yet. It was causing some problems as I tried different overlay scenarios.
[1] comment in line 81
https:/
Related branches
lp://staging/~kdub/mir/fix-1314399
- PS Jenkins bot (community): Approve (continuous-integration)
- Alberto Aguirre (community): Approve
- Alan Griffiths: Approve
- Daniel van Vugt: Approve
-
Diff: 63 lines (+45/-0)2 files modifiedsrc/platform/graphics/android/hwc_layerlist.cpp (+1/-0)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+44/-0)
Changed in mir: | |
status: | New → In Progress |
Changed in mir: | |
milestone: | none → 0.2.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir/devel at revision 1594, scheduled for release in mir, milestone Unknown