exit() is not sys.exit()
Bug #1314179 reported by
Vincent Ladeuil
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu CI Engine |
Fix Released
|
High
|
Vincent Ladeuil |
Bug Description
There is a difference between exit() and sys.exit(), the former closes sys.stdin (see site.py) which makes it impossible to debug tests that call it. This is aggravated by the fact that if one test calls it, sys.stdin is closed so any other attempt to debug a different test are screwed.
There is no other difference... both raise SystemExit otherwise.
https:/
"They are useful for the interactive interpreter shell and should not be used in programs."
I'll have a fix shortly available.
Related branches
lp://staging/~vila/uci-engine/1314179-sys-exit
- PS Jenkins bot (community): Approve (continuous-integration)
- Evan (community): Approve
-
Diff: 203 lines (+20/-16)12 files modifiedbin/create_lp_creds.py (+1/-1)
charms/precise/lander-jenkins/hooks/hooks.py (+1/-1)
charms/precise/rabbitmq-worker/hooks/hooks.py (+1/-1)
ci-utils/ci_utils/amqp_worker.py (+2/-1)
ci-utils/ci_utils/create_db.py (+3/-2)
juju-deployer/deploy.py (+1/-1)
lander/bin/lander_service_wrapper.py (+1/-1)
lander/lander/run_worker.py (+2/-1)
ppa-assigner/ppa_assigner/management/commands/clean_ppas.py (+3/-2)
ppa-assigner/setup.py (+2/-2)
test_runner/run_test.py (+1/-1)
ticket_system/setup.py (+2/-2)
Changed in uci-engine: | |
status: | In Progress → Fix Committed |
Changed in uci-engine: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.