Hide the headerbar's close button in preference window
Bug #1313440 reported by
Fabio Zaramella
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Midori Web Browser |
Won't Fix
|
Undecided
|
Unassigned | ||
| Noise |
Fix Released
|
Low
|
Fabio Zaramella | ||
| Photos |
Fix Released
|
Low
|
Fabio Zaramella | ||
| Scratch |
Fix Released
|
Low
|
Fabio Zaramella | ||
Bug Description
Hide close button from header bar in preference window because it looks a bit redundant since there is already the close button in the bottom right
Related branches
lp://staging/~fabiozaramella/noise/dont-use-headerbar
- xapantu (community): Approve
- Cody Garver: Pending requested
-
Diff: 53 lines (+19/-5)1 file modifiedsrc/Dialogs/PreferencesWindow.vala (+19/-5)
lp://staging/~fabiozaramella/scratch/fix-1313440
- xapantu (community): Approve
-
Diff: 165 lines (+64/-38)1 file modifiedsrc/Dialogs/PreferencesDialog.vala (+64/-38)
lp://staging/~fabiozaramella/pantheon-photos/fix-1313440
- Photos Devs: Pending requested
-
Diff: 59 lines (+14/-6)1 file modifiedsrc/Dialogs.vala (+14/-6)
| summary: |
- header bar for preference window + don't use header bar for preference window |
Revision history for this message
| Danielle Foré (danrabbit) wrote Re: don't use header bar for preference window | #1 |
| Changed in noise: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| Changed in noise: | |
| assignee: | nobody → Fabio Zaramella (ffabio-96-x) |
| status: | Confirmed → In Progress |
Revision history for this message
| Fabio Zaramella (fabiozaramella) wrote | #2 |
Revision history for this message
| Corentin Noël (tintou) wrote | #3 |
Revision history for this message
| Fabio Zaramella (fabiozaramella) wrote | #4 |
| Changed in noise: | |
| milestone: | none → freya-beta2 |
Revision history for this message
| Fabio Zaramella (fabiozaramella) wrote | #5 |
| summary: |
- don't use header bar for preference window + Hide the headerbar's close button in preference window |
| Changed in scratch: | |
| status: | New → In Progress |
| assignee: | nobody → Fabio Zaramella (ffabio-96-x) |
| description: | updated |
Revision history for this message
| oblv (oblv1) wrote | #6 |
| Changed in pantheon-photos: | |
| assignee: | nobody → Fabio Zaramella (ffabio-96-x) |
| status: | New → In Progress |
| Changed in noise: | |
| status: | In Progress → Fix Committed |
| Changed in scratch: | |
| status: | In Progress → Fix Committed |
| Changed in pantheon-photos: | |
| importance: | Undecided → Low |
| milestone: | none → freya-beta2 |
| status: | In Progress → Fix Released |
| Changed in scratch: | |
| milestone: | none → freya-beta2 |
| Changed in noise: | |
| status: | Fix Committed → Fix Released |
| Changed in scratch: | |
| status: | Fix Committed → Fix Released |
| Changed in scratch: | |
| milestone: | freya-beta2 → 2.1 |
| importance: | Undecided → Low |
| Changed in midori: | |
| status: | New → Won't Fix |
To post a comment you must log in.
I agree. This is not consistent with what we see in other apps (for example: Scratch).