allow annotations to be set on charms
Bug #1313016 reported by
Kapil Thangavelu
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Anastasia |
Bug Description
external tools (like deployer) would like to be set vcs info (repo url, rev) on local charms as the environment maintains local charm revisions, so api clients have no way of knowing when a local charm upload can be avoided since the charm is already in the env, which is costly for fat charms.
Changed in juju-core: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: api charms improvement |
Changed in juju-core: | |
importance: | High → Medium |
Changed in juju-core: | |
milestone: | none → 1.22 |
importance: | Medium → High |
Changed in juju-core: | |
assignee: | nobody → Anastasia (anastasia-macmood) |
Changed in juju-core: | |
status: | Triaged → In Progress |
Changed in juju-core: | |
milestone: | 1.22-alpha1 → 1.23 |
Changed in juju-core: | |
milestone: | 1.23 → 1.23-beta1 |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
New annotation client has been added deprecating the old one.
"Request" : "Set",
"Params" : {
"Annotations ": {{
"Entities" : {a, b, c},
" Annotations" : pairs1
},{
"Annotatio ns": pairs2
}}
This client still annotates entities that could be annotated before - environment, machine, service, unit. However, it also annotates charms.
New calls are capable of handling bulk inputs where bulk inputs mean:
1. For getting annotations:
Provide a list of entities of interest and get a list containing either entity annotations or retrieval error for each entity requested.
2. For setting annotations:
Note that this is a current assumption as it cateers for a lot of scenarios but complicates the call... FUrther clarification from Kapil or other interested parties may change that. Take a list of list of entities and its corresponding pairs, thus setting different annotations on a list of entities.
.......{
"Type": "Annotations",
"Entities": {d,e,a},
}}......
Here, entities a,b,c will be annotated with pairs1 whereas entities d,e,a with pairs2. Note that at the end of this call, entity a would have both pairs1 and pairs2 applied.
To keep track of clarifications, the other side of the coin is to list environment charms meeting the following requirements:
1. list of charm versioned urls present in the environment as simple array of strings;
2. provide parameter to filter charm list filter by charm name.