Cinder

The status change to retyping when cinder return error for the volumes reach maximum number

Bug #1308819 reported by yixuan zhang
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Mike Perez
Cinder 2014.2 "juno"
Icehouse
Fix Released
Low
Mike Perez
Cinder 2014.1.1

Bug Description

Do the below test:
1. Set the maximum number of volumes to 10 for user admin
2. Create type-1 on IBM-svc
3. Create type-7 on IBM-v7k
4. Create 10 volumes on type-1
5. Retype the volume from type-1 to type-7

The cinder will return error:

stack@ubuntu1310:/etc/cinder$ cinder retype --migration-policy on-demand 82cbafa7-949f-4c90-bde9-170507baa32f type-7
ERROR: VolumeLimitExceeded: Maximum number of volumes allowed (12) exceeded (HTTP 413) (Request-ID: req-15e2c0bb-e493-4ceb-a3f1-59d3c5282eff)

6. Check the volume status after that, it was found the status of the volume change to retyping , and keep on retyping after that.

| ID | Status | Name | Size | Volume Type | Bootable |
| 82cbafa7-949f-4c90-bde9-170507baa32f | retyping | 111 | 1 | type-1 | false |

It may because when retyping for migrate, it will have a template volume creation.
If the volumes has reached the maximum number, it can't create the template volume.
But if the retype command failed, the status for the volume should not change to retyping.
It is better keeping on available.

See original description
yixuan zhang (yixuan-z)
description: updated
Revision history for this message
Jay Bryant (jsbryant) wrote :

Is this bug really different than bug 1305550 ? A lot of discussion has developed around that bug ( see today's Cinder Weekly meeting http://eavesdrop.openstack.org/meetings/cinder/2014/cinder.2014-04-16-15.59.log.html ) and it has turned into a discussion of how to report failures like that that happen during a retype or migration, etc.

I would be inclined to roll this into that bug.

Regardless it is going to be discussed at the Summit.

Revision history for this message
Jason Ni (jason-ni-py) wrote :

I think this case is different. Because bug 1305550 is talking about unexpected error happend during retype process. But this error is decidable by checking volume nanumber under account. We could check that before doing retype, instead of triger the error during retype.

Mike Perez (thingee)
Changed in cinder:
status: New → In Progress
assignee: nobody → Mike Perez (thingee)
importance: Undecided → Low
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89718

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/89718
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3305f9dd061e70736fc4b890a207ecd4d30c3544
Submitter: Jenkins
Branch: master

commit 3305f9dd061e70736fc4b890a207ecd4d30c3544
Author: Mike Perez <email address hidden>
Date: Tue Apr 22 16:27:42 2014 -0700

    Keep volume available if retype fails due to quota

    If we're over quota for a volume type that we're retyping a volume to,
    keep the volume available.

    Closes-Bug: #1308819
    Change-Id: I7e66e95bf12b7e5a6df04eeb5a501badb5f2941f

Changed in cinder:
status: In Progress → Fix Committed
Mike Perez (thingee)
tags: added: icehouse-backport-potential
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/90642

Mike Perez (thingee)
Changed in cinder:
milestone: none → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to cinder (stable/icehouse)

Reviewed: https://review.openstack.org/90642
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=767c2a6407c3a1fed2466ac244e9579bd2339cf2
Submitter: Jenkins
Branch: stable/icehouse

commit 767c2a6407c3a1fed2466ac244e9579bd2339cf2
Author: Mike Perez <email address hidden>
Date: Tue Apr 22 16:27:42 2014 -0700

    Keep volume available if retype fails due to quota

    If we're over quota for a volume type that we're retyping a volume to,
    keep the volume available.

    Closes-Bug: #1308819
    Change-Id: I7e66e95bf12b7e5a6df04eeb5a501badb5f2941f
    (cherry picked from commit 3305f9dd061e70736fc4b890a207ecd4d30c3544)

tags: added: in-stable-icehouse
Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.