missing import and syntax error in external-auth doc code example

Bug #1308634 reported by Matthieu Huin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Matthieu Huin

Bug Description

The documentation about external authentication provides some boilerplate code to write a custom authentication middleware, but the code contains a few errors:

* missing keystone.exception import
* trailing : in line "username = self.do_auth(request):"

Matthieu Huin (mhu-s)
Changed in keystone:
assignee: nobody → Matthieu Huin (mhu-s)
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88014

Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/88014
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=0473e5ab75ece62df8b7bb429c9e75db34ce71f6
Submitter: Jenkins
Branch: master

commit 0473e5ab75ece62df8b7bb429c9e75db34ce71f6
Author: Matthieu Huin <email address hidden>
Date: Wed Apr 16 17:58:48 2014 +0200

    Add missing import, remove trailing ":" in middleware example

    Minor fixes to the external authentication example given in the
    documentation.

    Change-Id: I2bef7da8bf8278349fec80a513095637ea49f19a
    Closes-Bug: #1308634
    Co-Authored-By: Florent Flament <email address hidden>

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.