Player spots have randomly colored borders in multiplayer setup
Bug #1307199 reported by
Hans Joachim Desserud
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
Steps to reproduce:
1. Main menu -> Multiplayer -> Local -> Host a new game.
2. Pick a map.
3. Observe the list of available player spots.
Some of them (randomly selected) have borders around the player markers drawn with (again) random colors. I haven't really found a pattern here, sometimes the borders are shown, sometimes not. The border color might be the same as the player token, but more often it is not. See attached screenshot for an example.
Widelands r6934 on Ubuntu 13.10 (opengl rendering is on)
Related branches
lp://staging/~widelands-dev/widelands/multiplayer_dropdowns_2_init_team
- SirVer: Needs Fixing
-
Diff: 2254 lines (+767/-580)25 files modifiedsrc/ai/computer_player.cc (+7/-6)
src/ai/computer_player.h (+17/-0)
src/ai/defaultai.h (+21/-18)
src/base/macros.h (+4/-0)
src/graphic/playercolor.h (+13/-0)
src/logic/CMakeLists.txt (+1/-0)
src/logic/game.cc (+3/-3)
src/logic/game_settings.h (+19/-2)
src/logic/single_player_game_settings_provider.cc (+8/-7)
src/network/gameclient.cc (+6/-4)
src/network/gameclient.h (+1/-1)
src/network/gamehost.cc (+30/-101)
src/network/network_player_settings_backend.cc (+118/-79)
src/network/network_player_settings_backend.h (+10/-12)
src/network/network_protocol.h (+3/-2)
src/notifications/note_ids.h (+3/-1)
src/ui_basic/dropdown.cc (+67/-12)
src/ui_basic/dropdown.h (+31/-2)
src/ui_basic/listselect.cc (+2/-2)
src/ui_fsmenu/launch_game.cc (+5/-6)
src/ui_fsmenu/launch_mpg.cc (+12/-10)
src/ui_fsmenu/launch_spg.cc (+5/-5)
src/wui/multiplayersetupgroup.cc (+372/-298)
src/wui/multiplayersetupgroup.h (+2/-2)
src/wui/playerdescrgroup.cc (+7/-7)
lp://staging/~widelands-dev/widelands/multiplayer_dropdowns
- SirVer: Approve (testing,compile,code-review)
- kaputtnik (community): Approve (testing)
-
Diff: 2785 lines (+1002/-778)29 files modifiedsrc/ai/computer_player.cc (+7/-6)
src/ai/computer_player.h (+17/-0)
src/ai/defaultai.h (+21/-18)
src/graphic/playercolor.h (+13/-0)
src/logic/CMakeLists.txt (+1/-0)
src/logic/game.cc (+3/-3)
src/logic/game_settings.cc (+38/-1)
src/logic/game_settings.h (+47/-3)
src/logic/single_player_game_settings_provider.cc (+9/-8)
src/logic/single_player_game_settings_provider.h (+1/-1)
src/network/CMakeLists.txt (+0/-1)
src/network/gameclient.cc (+11/-6)
src/network/gameclient.h (+2/-2)
src/network/gamehost.cc (+76/-113)
src/network/gamehost.h (+1/-1)
src/network/network_player_settings_backend.cc (+58/-123)
src/network/network_player_settings_backend.h (+9/-20)
src/network/network_protocol.h (+3/-2)
src/notifications/note_ids.h (+3/-1)
src/ui_basic/dropdown.cc (+67/-12)
src/ui_basic/dropdown.h (+31/-2)
src/ui_basic/listselect.cc (+2/-2)
src/ui_fsmenu/launch_game.cc (+5/-6)
src/ui_fsmenu/launch_mpg.cc (+30/-20)
src/ui_fsmenu/launch_mpg.h (+1/-0)
src/ui_fsmenu/launch_spg.cc (+5/-5)
src/wui/multiplayersetupgroup.cc (+528/-409)
src/wui/multiplayersetupgroup.h (+6/-6)
src/wui/playerdescrgroup.cc (+7/-7)
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #1 |
Revision history for this message
| wl-zocker (wl-zocker) wrote | #2 |
| Changed in widelands: | |
| status: | New → Confirmed |
Revision history for this message
| SirVer (sirver) wrote | #3 |
| Changed in widelands: | |
| status: | Confirmed → Incomplete |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #4 |
| Changed in widelands: | |
| status: | Incomplete → Confirmed |
| assignee: | nobody → GunChleoc (gunchleoc) |
| Changed in widelands: | |
| assignee: | GunChleoc (gunchleoc) → nobody |
| milestone: | build19-rc1 → none |
| Changed in widelands: | |
| milestone: | none → build20-rc1 |
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #5 |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #6 |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #7 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I can reproduce this on r6933. There is no difference whether OpenGL is enabled or not.
When I start a Widelands and do this for the first time in r6931, there are no borders. When I then go back to the main menu and again to the multiplayer menu, the borders are shown. This is no longer the case in r6933: Here, the borders show up from the first time I follow the steps.