Mixxx

Decks shouldn't sync to samplers

Bug #1302258 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Owen Williams
Mixxx 2.3.0

Bug Description

If a beatgridded track is loaded in a sampler and the user pushes sync on a deck, that deck will pick up the BPM from the sampler. Samplers should be explicit second-class citizens and this shouldn't be allowed.

My inclination is to add a bool to EngineChannel called isFullDeck or something, which only real decks would have. Then in the sync code I can check to see if something is a fully-featured deck and only sync to it if so.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Sound good. What about "canBeSyncMaster" or something.

Changed in mixxx:
status: New → Confirmed
Revision history for this message
jus (jus) wrote :

I think doing this would be an error we need to clean up later.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Is there a use case where a sampler is sync master?

Revision history for this message
Owen Williams (ywwg) wrote :

Yeah, eventually someone may want a click track to be master and they might do that by putting a sampler on a loop.

Changed in mixxx:
assignee: nobody → Owen Williams (ywwg)
Be (be.ing)
Changed in mixxx:
assignee: Owen Williams (ywwg) → nobody
milestone: 2.0.0 → none
Revision history for this message
JosepMa (josepma) wrote :

Updating this bug with more relevant info, so that it can be taken into consideration:

Since 2.0, we have the master sync option that we can activate on the decks. (This cannot be activated on a sampler)

If I have two decks playing with master sync, press play on a sampler (there's not even a need for the sampler to be loaded!) and then either press stop/cue/play, or song ends, or even load a song on one deck, the other playing deck tries to sync to the sampler.
Since master sync is enabled, it does so by slightly accelerating the playback until it thinks it synced with the sampler.

I wonder if we should consider adding master sync ability to samplers, and only if they have it enabled, check if they are playing in order to sync to them. Else, ignore them.

Revision history for this message
Be (be.ing) wrote :

Yes, eventually sync should work with short samples. In the meantime, I think hacking sync to ignore samplers is a good enough workaround.

Revision history for this message
JosepMa (josepma) wrote :

Addition (since i can't edit).

I had quantize activated on the decks. It wasn't active on the sampler.

Daniel Schürmann (daschuer)
Changed in mixxx:
status: Confirmed → In Progress
milestone: none → 2.3.0
assignee: nobody → Owen Williams (ywwg)
Revision history for this message
Be (be.ing) wrote :

https://github.com/mixxxdj/mixxx/pull/2732

Changed in mixxx:
milestone: 2.3.0 → none
milestone: none → 2.3.0
status: In Progress → Fix Committed
Daniel Schürmann (daschuer)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7401

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.