utils/ssh: test failures
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Andrew Wilkins |
Bug Description
Happens under gc and gccgo, the test is probably using a map to collect the set of options.
lucky(~
-------
FAIL: ssh_test.go:94: SSHCommandSuite
[LOG] 0:00.000 DEBUG juju.utils.ssh running: ssh -o "StrictHostKeyC
ssh_test.go:99:
s.assertCom
s.fakessh+" -o StrictHostKeyCh
)
ssh_test.go:57:
c.Assert(
... obtained string = "/tmp/gocheck-
... expected string = "/tmp/gocheck-
-------
FAIL: ssh_test.go:126: SSHCommandSuite
[LOG] 0:00.000 DEBUG juju.utils.ssh running: scp -o "StrictHostKeyC
ssh_test.go:137:
// EnablePTY has no effect for Copy
c.Assert(
... obtained string = "/tmp/gocheck-
... expected string = "/tmp/gocheck-
OOPS: 41 passed, 2 FAILED
--- FAIL: Test (10.32 seconds)
FAIL
FAIL launchpad.
Related branches
- Juju Engineering: Pending requested
-
Diff: 121 lines (+13/-45)1 file modifiedutils/ssh/ssh_openssh.go (+13/-45)
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
This was changed, I'm told, to ease debugging. I think I'll just put it back to using a slice with known order.