Cinder

test_volume_get_all_filters_limit incorrectly asserts certain metadata ordering

Bug #1293792 reported by Alex Meade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Juan Manuel Ollé
Cinder 2014.2 "juno"
Icehouse
Fix Released
Medium
Matt Riedemann
Cinder 2014.1.1

Bug Description

cinder.tests.test_db_api.DBAPIVolumeTestCase.test_volume_get_all_filters_limit

This test indirectly asserts that the metadata on a volume is returned in a certain order. This is incorrect because python dictionaries to not maintain ordering. This causes spuratic unit test failures with this error:

http://paste.openstack.org/show/73692/

Juan Manuel Ollé (juan-m-olle)
Changed in cinder:
assignee: nobody → Juan Manuel Ollé (juan-m-olle)
OpenStack Infra (hudson-openstack)
Changed in cinder:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/82177
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4cc2366623743393f89a198581fcb69dc04d31cd
Submitter: Jenkins
Branch: master

commit 4cc2366623743393f89a198581fcb69dc04d31cd
Author: Juan Manuel Olle <email address hidden>
Date: Fri Mar 21 16:46:03 2014 -0300

    Correct metadata ordering issue in tests

    Some test including test_volume_get_all_filters
    fails randomly because metadata is in a dict and
    the items order is undefined.
    The test comparison was changed to avoid unexpected
    test results.

    Change-Id: Ibb24d21cd05aa1eefb45b61c63de067b34fb1013
    Closes-Bug: #1293792

Changed in cinder:
status: In Progress → Fix Committed
Matt Riedemann (mriedem)
tags: added: icehouse-backport-potential
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/91039

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to cinder (stable/icehouse)

Reviewed: https://review.openstack.org/91039
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=59fe59ebfc93a9354aa4598a39c7132cc38938fe
Submitter: Jenkins
Branch: stable/icehouse

commit 59fe59ebfc93a9354aa4598a39c7132cc38938fe
Author: Juan Manuel Olle <email address hidden>
Date: Fri Mar 21 16:46:03 2014 -0300

    Correct metadata ordering issue in tests

    Some test including test_volume_get_all_filters
    fails randomly because metadata is in a dict and
    the items order is undefined.
    The test comparison was changed to avoid unexpected
    test results.

    Change-Id: Ibb24d21cd05aa1eefb45b61c63de067b34fb1013
    Closes-Bug: #1293792
    (cherry picked from commit 4cc2366623743393f89a198581fcb69dc04d31cd)

tags: added: in-stable-icehouse
Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
Alan Pevec (apevec)
Changed in cinder:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.