Oauth manager created multiple times

Bug #1291705 reported by Brant Knudson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Brant Knudson

Bug Description

The oauth1.Manager class, which is @dependency.provider('oauth_api'), is created multiple times when it should only be created once. A 'provider' should only be created once because otherwise the new instance replaces the one that's stored in the dependency map. Luckily, the oauth1.Manager doesn't store any state so it's safe to do in this case, but it makes for a bad example that others are copying and it might not be safe in those cases.

Brant Knudson (blk-u)
Changed in keystone:
assignee: nobody → Brant Knudson (blk-u)
Changed in keystone:
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/79213
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=ee72c9042989ecfa52ff46ab20342008db969822
Submitter: Jenkins
Branch: master

commit ee72c9042989ecfa52ff46ab20342008db969822
Author: Brant Knudson <email address hidden>
Date: Sun Mar 9 18:27:15 2014 -0500

    Remove unnecessary oauth1.Manager constructions

    There's an oauth1.Manager kept in the global dependency that's
    created when the oauth1 extension is loaded due to being in the
    paste pipeline, so there's no need to create more of them.

    Closes-Bug: #1291705
    Change-Id: I78e19e3b165b4cd503e2da6a135daa54e98de599

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.