Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC

wsrep_start_replication wsrep->connect rcode matching

Bug #1290526 reported by Raghavendra D Prabhu on 2014-03-10

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
MySQL patches by Codership	Fix Committed	High	Unassigned
5.5	Fix Committed	High	Unassigned	MySQL patches by Codership 5.5.38-25.11
Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC	Status tracked in 5.6
5.5	Fix Released	High	Alexey Kopytov	Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC future-5.5
5.6	Fix Released	High	Alexey Kopytov	Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC 5.6.24-25.11

Bug Description

/tmp/bld/sql/wsrep_mysqld.cc:776:26: warning: comparison of constant -94 with expression of type 'wsrep_status_t' (aka 'wsrep_status') is always false [-Wtautological-constant-out-of-range-compare]
if (-ESOCKTNOSUPPORT == rcode)

wsrep->connect() doesn't return anything else other than in wsrep_status_t, so that is always false.

Tags:

Revision history for this message

Yan Zhang (yan.zhang) wrote on 2014-05-13:

I think we can put rcode to errno inside wsrep->connect, since return type wsrep_status_t could only presents few status.

And change wsrep-mysql code as

=== modified file 'sql/wsrep_mysqld.cc'
--- sql/wsrep_mysqld.cc 2014-05-04 07:12:59 +0000
+++ sql/wsrep_mysqld.cc 2014-05-13 08:53:08 +0000
@@ -810,19 +810,8 @@
                               wsrep_sst_donor,
                               bootstrap)))
   {
- if (-ESOCKTNOSUPPORT == rcode)
- {
- DBUG_PRINT("wsrep",("unrecognized cluster address: '%s', rcode: %d",
- wsrep_cluster_address, rcode));
- WSREP_ERROR("unrecognized cluster address: '%s', rcode: %d",
- wsrep_cluster_address, rcode);
- }
- else
- {
- DBUG_PRINT("wsrep",("wsrep->connect() failed: %d", rcode));
- WSREP_ERROR("wsrep::connect() failed: %d", rcode);
- }
-
+ DBUG_PRINT("wsrep",("wsrep->connect(%s) failed: %m", wsrep_cluster_address));
+ WSREP_ERROR("wsrep->connect(%s) failed: %m", wsrep_cluster_address);
     return false;
   }
   else