Ticket gets marked as 'Complete' (passed) when the package has a failing test
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu CI Engine |
Fix Released
|
Critical
|
Vincent Ladeuil | ||
Ubuntu CI Services |
Fix Released
|
Critical
|
Vincent Ladeuil |
Bug Description
I created a failing test in autopkgtest to see what would happen... It turns out, bad things happen... The ticket was marked as completed instead of failed.
I added the following to tests/adt-run:
def test_chris_
autopkgtest-
test: dsc0t-adt-run
error: dsc0t-adt-run [ multipart
Content-Type: text/plain;
error
36
adt-run produced an unexpected result: "dsc0t-adt-run"0
]
test: dsc0t-pyflakes
successful: dsc0t-pyflakes [ multipart
Content-Type: text/plain;
stderr
0
Content-Type: text/plain;
stdout
0
]
17:32:26 fginther | oooh, I wonder if this package has multiple tests and we
17:32:45 fginther | we're only checking the return code of the last one.
17:33:03 fginther | because the pyflakes test passed
Related branches
- Chris Johnston (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Andy Doan (community): Approve
-
Diff: 28 lines (+4/-4)2 files modifiedjuju-deployer/deploy.py (+1/-1)
test_runner/tstrun/testbed.py (+3/-3)
Changed in ubuntu-ci-services-itself: | |
status: | New → Confirmed |
importance: | High → Critical |
status: | Confirmed → In Progress |
Changed in ubuntu-ci-services-itself: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ci-services-itself: | |
status: | Fix Committed → Fix Released |
Changed in uci-engine: | |
assignee: | nobody → Vincent Ladeuil (vila) |
importance: | Undecided → Critical |
milestone: | none → phase-0 |
status: | New → Fix Released |
Vincent - any ideas?