oslo.messaging

PublishErrorsHandler is named poorly

Bug #1287420 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Wishlist
Ilya Pekelny
oslo.messaging 1.5.0

Bug Description

It isn't clear that the class is related to logging. We probably want to call it something like LoggingErrorPublishingHandler or LoggingErrorNotificationHandler (to be similar to the LoggingNotificationHandler). We can't remove the old name entirely, but we can rename the class, update the docs, and include an alias from the old name to the new class for backwards-compatibility.

Doug Hellmann (doug-hellmann)
Changed in oslo.messaging:
status: New → Triaged
importance: Undecided → Wishlist
Ilya Pekelny (i159)
Changed in oslo.messaging:
assignee: nobody → Ilya Pekelny (i159)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/123389

Changed in oslo.messaging:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/123389
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=e15cd36cd5d9150bde784d559fbaad882f5cfbfe
Submitter: Jenkins
Branch: master

commit e15cd36cd5d9150bde784d559fbaad882f5cfbfe
Author: Ilya Pekelny <email address hidden>
Date: Tue Sep 23 10:52:19 2014 +0300

    Renamed PublishErrorsHandler

    For greater clarity, that the class is related to logging, PublishErrorsHandler
    renamed to LoggingErrorNotificationHandler. Included an alias from the
    old name to the new class for backwards-compatibility.

    Change-Id: Iae8e26901bab6d5aa7532add31b49a4345b067fe
    Closes-Bug: #1287420

Changed in oslo.messaging:
status: In Progress → Fix Committed
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
milestone: none → 1.5.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.