Midori Web Browser

"Open" on downloads is broken

Bug #1286971 reported by gue5t gue5t on 2014-03-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Midori Web Browser	Fix Released	Critical	Unassigned	Midori Web Browser 0.5.8 "Unicorns and pixies"

Bug Description

In the Save/Save-As/Open/Cancel dialog for downloads, the "Open" option always reports the download as erroneous and then fails to open the downloaded file.

Try on <http://www.seas.upenn.edu/~sweirich/talks/GADT.pdf>, for example.

The code in midori-download.vala reports the error regardless of whether it happened, and the call to get the "tab" property from the widget passes the variable's value (NULL) instead of the address of the variable.

Tags:

Related branches

lp://staging/~gue5t/midori/fix-download-open

Merged into lp://staging/midori at revision 6588

Paweł Forysiuk: Approve on 2014-03-06

gue5t gue5t (gue5t) on 2014-03-03

Changed in midori:
importance:	Undecided → Critical

Cris Dywan (kalikiana) on 2014-03-03

Changed in midori:
milestone:	none → 0.5.8

gue5t gue5t (gue5t) on 2014-03-06

Changed in midori:
status:	New → Fix Committed

Cris Dywan (kalikiana) on 2014-04-03

Changed in midori:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.