OpenStack Identity (keystone)

keystone-manage db_version broken

Bug #1284341 reported by Steven Hardy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Steven Hardy
OpenStack Identity (keystone) 2014.1 "icehouse"

Bug Description

A recent commit appears to have broken keystone-manage:

keystone-manage db_version
2014-02-24 21:29:17.392 CRITICAL keystone [-] TypeError: db_version() takes exactly 2 arguments (1 given)

It appears to be a regression caused by this patch which was recently merged:

https://review.openstack.org/#/c/61073/36/keystone/cli.py

The ")"'s on the print statements look to be in the wrong place AFAICS.

Steven Hardy (shardy)
Changed in keystone:
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76009

Changed in keystone:
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/76009
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=1991c3d9b98f791d4a2087e156396bbf0e82613e
Submitter: Jenkins
Branch: master

commit 1991c3d9b98f791d4a2087e156396bbf0e82613e
Author: Steven Hardy <email address hidden>
Date: Mon Feb 24 21:33:30 2014 +0000

    Fix keystone-manage db_version

    A recently merged change broke the db_version by passing the value for
    init_version to the print rather than the db_version call.

    Change-Id: I5ec4269fb89a99e1b303fdd8b2b3d991fc23c883
    Closes-Bug: #1284341

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Revision history for this message
Lance Bragstad (lbragstad) wrote :

I am seeing this again on a240705b07b852616e39a2b93253f0a9a09a3ef9

lbragstad@precise64:/opt/stack/keystone/bin$ ./keystone-manage db_version
2014-03-08 15:27:01.056 CRITICAL keystone [-] TypeError: db_version() takes exactly 3 arguments (2 given)

lbragstad@precise64:/opt/stack/keystone/bin$

I know there have been recent merges to keystone/cli.py so there might have been something caused this to regress.

Revision history for this message
Lance Bragstad (lbragstad) wrote :

I can grab the right db_version when I back up to the commit before the Token Revocation work. Steps to reproduce:

1.) lbragstad@precise64:/opt/stack/keystone/bin$ git checkout 1ba6c53bade4679d940fa311800d29038cf26358
2.) lbragstad@precise64:/opt/stack/keystone/bin$ ./keystone-manage db_version
2014-03-08 15:29:14.757 WARNING keystone.openstack.common.db.sqlalchemy.session [-] This application has not enabled MySQL traditional mode, which means silent data corruption may occur. Please encourage the application developers to enable this mode.
43

This might have something to do with it? https://review.openstack.org/#/c/55908/82/keystone/cli.py

I think that is the only change on keystone/cli.py that has happened since Steven's fix went in?

Revision history for this message
Dolph Mathews (dolph) wrote :

Re-opening since this is so recent.

Changed in keystone:
status: Fix Released → Triaged
milestone: icehouse-3 → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79196

Changed in keystone:
assignee: Steven Hardy (shardy) → Brant Knudson (blk-u)
status: Triaged → In Progress
Brant Knudson (blk-u)
Changed in keystone:
assignee: Brant Knudson (blk-u) → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/79196
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=fbfd4e888e71007730ad173b13b9c430228ba6a2
Submitter: Jenkins
Branch: master

commit fbfd4e888e71007730ad173b13b9c430228ba6a2
Author: Brant Knudson <email address hidden>
Date: Sun Mar 9 11:54:44 2014 -0500

    Fix db_version failed with wrong arguments

    The `keystone-manage db_version` command was failing with an error
    like

     TypeError: db_version() takes exactly 2 arguments (1 given)

    This is because an engine wasn't being passed to db_version().

    Change-Id: I20b4cb10f9c83fc672de2838bac8236938b92e32
    Closes-Bug: #1284341

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.