Sahara

Processes are case sensitive in Sahara API and case insensitive in internal utility methods

Bug #1282806 reported by Andrew Lazarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Medium
Andrew Lazarev
Sahara 2014.2 "juno"

Bug Description

savanna/plugins/general/utils.py should be case sensitive

Andrew Lazarev (alazarev)
summary: - Processes are case sensitive in Savanna API and not case sensitive in
+ Processes are case sensitive in Savanna API and case insensitive in
internal utility methods
Revision history for this message
Sergey Lukjanov (slukjanov) wrote : Re: Processes are case sensitive in Savanna API and case insensitive in internal utility methods

Fix: https://review.openstack.org/#/c/73716/

Changed in savanna:
milestone: none → icehouse-3
assignee: nobody → Andrew Lazarev (alazarev)
importance: Undecided → Medium
status: New → Triaged
status: Triaged → In Progress
Revision history for this message
Matthew Farrellee (mattf) wrote :

from a user perspective, there's no need to care about case for process names.

i'd like the process names inbound from the api to be case insensitive.

in fact, we shouldn't be case sensitive for job types either.

Revision history for this message
Andrew Lazarev (alazarev) wrote :

@Matt This bug has nothing to do with API. Currently API validation checks process name case sensitive. I'm fully Ok with changing this behavior. But IMHO internally processes need to be stored unified.

Sergey Lukjanov (slukjanov)
Changed in savanna:
milestone: icehouse-3 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/73716
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=1b48f5b56a6703a64e3c40c84fba5248db0b9c52
Submitter: Jenkins
Branch: master

commit 1b48f5b56a6703a64e3c40c84fba5248db0b9c52
Author: Andrew Lazarev <email address hidden>
Date: Fri Feb 14 13:16:58 2014 -0800

    Made processes names case sensitive

    Current approach "store name in any case, but search in lowercase" was
    done to work with HDP uppercase processes. Since process manipulation
    logic was moved to plugins, replaced approach to case sensitive use.

    Closes-Bug: #1282806
    Change-Id: I4a8d65b750135a8521f26c6e6c2d9311f3281b14

Changed in sahara:
status: In Progress → Fix Committed
Sergey Lukjanov (slukjanov)
Changed in sahara:
milestone: next → juno-1
Sergey Lukjanov (slukjanov)
summary: - Processes are case sensitive in Savanna API and case insensitive in
+ Processes are case sensitive in Sahara API and case insensitive in
internal utility methods
Thierry Carrez (ttx)
Changed in sahara:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in sahara:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.