config generator returns wrong value for CONF.host parameter
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Fix Released
|
Medium
|
Viktor Serhieiev | ||
oslo-incubator |
Fix Released
|
Medium
|
Yuriy Zveryanskyy |
Bug Description
CONF.host parameter get it's default value as socket.getfqdn(), see [1], but in config generator we check, if default value of CONF.host equal with socket.
Python documentation says, that " gethostname() doesn’t always return the fully qualified domain name". See [4]. So it caused pep-8 failures as on patch set 1 in patches [5] and [6].
[1] https:/
[2] https:/
[3] https:/
[4] http://
[5] https:/
[6] https:/
Changed in ironic: | |
status: | New → Confirmed |
Changed in ironic: | |
assignee: | nobody → Xurong Yang (idopra) |
Changed in oslo: | |
assignee: | nobody → Xurong Yang (idopra) |
Changed in oslo: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in ironic: | |
importance: | Undecided → Medium |
Changed in oslo: | |
milestone: | none → icehouse-3 |
Changed in ironic: | |
assignee: | Xurong Yang (idopra) → Victor Sergeyev (vsergeyev) |
status: | Confirmed → In Progress |
Changed in ironic: | |
milestone: | none → icehouse-3 |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | icehouse-3 → 2014.1 |
Changed in ironic: | |
milestone: | icehouse-3 → 2014.1 |
I think this is an Oslo bug.
Possible fix in Oslo code
elif value in (socket. gethostname( ), socket.getfqdn()) and 'host' in name:
here
https:/ /github. com/openstack/ oslo-incubator/ blob/master/ openstack/ common/ config/ generator. py#L229