Ubuntu
nautilus package

ubuntu_show_titlebar.patch: XDG_CURRENT_DESKTOP is not correctly compared with GNOME

Bug #1277963 reported by Matthieu Baerts
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
nautilus (Ubuntu)
Invalid
Medium
Unassigned

Bug Description

Hello,

Currently in ubuntu_show_titlebar.patch, 'g_strcmp0' function is used but the result is not compared to 0.

According to the GLib Reference Manual: just like "strcmp", this function returns an integer less than, equal to, or greater than zero, if str1 is <, == or > than str2.

Adolfo Jayme Barrientos (fitojb)
Changed in nautilus (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report. What do you mean "the result is not compared to 0"?

the code does
" if (!g_strcmp0(g_getenv("XDG_CURRENT_DESKTOP"), "GNOME")) {"

g_strcmp0() returns 0 if the strings match, or 0 = FALSE, so writting "!g_strcmp0..." is equivalent of "if strings match"

Revision history for this message
Matthieu Baerts (matttbe) wrote :

Sorry, I should really take a break :(

Changed in nautilus (Ubuntu):
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.