Test plugin should set SSH_AGENT_PID and SSH_AGENT_SOCK if declared
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charm Tools |
Fix Released
|
Undecided
|
David Britton |
Bug Description
Otherwise, when you need to branch charms that you are developing/testing, you get prompted for your key passphrase.
2014-01-22 20:17:04 Starting deployment of cstack2
Enter passphrase for key '/home/
Enter passphrase for key '/home/
Enter passphrase for key '/home/
Enter passphrase for key '/home/
Enter passphrase for key '/home/
After some testing, I have just inserted the following:
class Conductor(object):
def __init__(self, arguments=None):
self.args = arguments
self.env = {'JUJU_HOME': os.path.
+ self.env.
Which seems to be working fine. In thinking things out, passing env variables down to the script seems to be pretty necessary for any kind of test framework.
Related branches
- Marco Ceppi (community): Approve
-
Diff: 50 lines (+22/-0)2 files modifiedcharmtools/test.py (+4/-0)
tests/test_juju_test.py (+18/-0)
description: | updated |
Changed in charm-tools: | |
assignee: | nobody → David Britton (davidpbritton) |
status: | New → In Progress |
Changed in charm-tools: | |
milestone: | none → 1.2.9 |
Changed in charm-tools: | |
status: | In Progress → Fix Committed |
Changed in charm-tools: | |
status: | Fix Committed → Fix Released |
Also, I notice that things like "juju ssh" in a test doesn't work without this change, you get "ssh not found in path".