need consistent rules for retrying ftp transport operations
Bug #127164 reported by
Vincent Ladeuil
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Wishlist
|
Unassigned | ||
Breezy |
Won't Fix
|
Wishlist
|
Unassigned |
Bug Description
The ftp transport internally handles temporary errors inconsistently.
Sometimes we reconnect, sometimes we raise an exception.
Care should be taken to analyze the implications for write operations (read operations are safe to retry).
Overall even some read operations are never retried.
Related branches
lp://staging/~jelmer/brz/no-more-ftp
Merged
into
lp://staging/brz
- Vincent Ladeuil: Approve
- Martin Packman: Approve
-
Diff: 1510 lines (+17/-1308)16 files modifiedbreezy/help_topics/en/authentication.txt (+3/-3)
breezy/lockdir.py (+0/-3)
breezy/plugins/git/tests/test_dir.py (+1/-1)
breezy/plugins/upload/__init__.py (+1/-1)
breezy/plugins/upload/tests/test_upload.py (+1/-25)
breezy/tests/__init__.py (+0/-6)
breezy/tests/blackbox/test_help.py (+0/-2)
breezy/tests/ftp_server/__init__.py (+0/-82)
breezy/tests/ftp_server/pyftpdlib_based.py (+0/-223)
breezy/tests/test_ftp_transport.py (+0/-151)
breezy/tests/test_http.py (+2/-2)
breezy/tests/test_smart_transport.py (+1/-1)
breezy/tests/transport_util.py (+8/-19)
breezy/transport/__init__.py (+0/-23)
breezy/transport/ftp/__init__.py (+0/-638)
breezy/transport/ftp/_gssapi.py (+0/-128)
Changed in bzr: | |
assignee: | nobody → v-ladeuil |
tags: | added: check-for-breezy |
Changed in brz: | |
status: | New → Triaged |
importance: | Undecided → Wishlist |
tags: |
added: ftp removed: check-for-breezy |
Changed in brz: | |
milestone: | none → 3.0.0 |
status: | Triaged → Won't Fix |
To post a comment you must log in.
What should be done? An audit of the ftp transport code? Or some structural change?
It seems like we ought to be able to describe some operations as retryable regardless of the particular protocol.