Erroneous use of last_consumed in SwitchingBundle::compositor_acquire
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Daniel d'Andrada | ||
mir (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
SwitchingBundle
TEST_F(
{
int nbuffers = 3;
mc:
mg::Buffer* client_buffer = nullptr;
//(
client_buffer = bundle.
//(
bundle.
//(
client_buffer = bundle.
//(
bundle.
//(
// Should be:
//(
bundle.
//(
// Should be:
//(
client_buffer = bundle.
}
Merge proposal with fix will come shortly...
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Approve
- Alan Griffiths: Abstain
- Andreas Pokorny (community): Approve
- Alexandros Frantzis (community): Approve
-
Diff: 88 lines (+34/-4)3 files modifiedsrc/server/compositor/switching_bundle.cpp (+1/-2)
src/server/compositor/switching_bundle.h (+3/-1)
tests/unit-tests/compositor/test_switching_bundle.cpp (+30/-1)
- Alan Griffiths: Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 22 lines (+15/-0)1 file modifiedtests/unit-tests/compositor/test_switching_bundle.cpp (+15/-0)
Changed in mir: | |
assignee: | nobody → Daniel d'Andrada (dandrader) |
description: | updated |
Changed in mir: | |
status: | New → In Progress |
Changed in mir: | |
milestone: | none → 0.1.5 |
importance: | Undecided → Medium |
Changed in mir: | |
importance: | Medium → Low |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Dropped importance. It looks like Mir actually won't and can't experience this bug... Because frameno starts at 1 and last_consumed is initialized to 0.
bool same_frame = (frameno == last_consumed);