OpenStack Identity (keystone)

oauth fails with pre 0.6.0 oauthlib

Bug #1270909 reported by Brant Knudson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Brant Knudson
OpenStack Identity (keystone) 2014.1 "icehouse"

Bug Description

Keystone was recently changed to use oauthlib. The requirements for keystone don't specify a required level for oauthlib, but it turns out that Keystone doesn't work with pre-0.6.0 versions of oauthlib.

The unit tests fail with 0.5.1 with a stacktrace like

  File "keystone/contrib/oauth1/controllers.py", line 191, in create_request_token
    headers=req_headers)
  ValueError: too many values to unpack

So either Keystone should be changed to work with earlier versions of authlib or the requirement should be updated.

Revision history for this message
Brant Knudson (blk-u) wrote :

I plan to update the requirement.

Changed in keystone:
assignee: nobody → Brant Knudson (blk-u)
Revision history for this message
Brant Knudson (blk-u) wrote :

Here's the oauthlibs: https://pypi.python.org/simple/oauthlib/

Revision history for this message
Brant Knudson (blk-u) wrote :

Looks like openstack is typically using 0.6.0: http://pypi.openstack.org/openstack/oauthlib/

Revision history for this message
Brant Knudson (blk-u) wrote :

Proposed change to requirements: https://review.openstack.org/#/c/67900/

If that's accepted, can update requirements in keystone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/70240

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/70240
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7599d9655371e65d063d290f871dc2e5002d9b29
Submitter: Jenkins
Branch: master

commit 7599d9655371e65d063d290f871dc2e5002d9b29
Author: Brant Knudson <email address hidden>
Date: Thu Jan 30 16:53:00 2014 -0600

    Update requirements to 661e6

    The requirements are updated to requirements project commit
    661e6bad9e56dddd65a200dc08aedc00b9656312

     $ cd /opt/stack/requirements
     $ python update.py ../keystone

    bp s3-token-to-keystoneclient

    Closes-Bug: #1270909
    Closes-Bug: #1277583
    Related-Bug: #1178741
    Change-Id: If7ddef69076e1b03c5efbf4f05bb349bbecfa015

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.