OpenStack Identity (keystone)

an improvement of curl example doc?

Bug #1269739 reported by Kun Huang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Krsna
OpenStack Identity (keystone) 2014.1 "icehouse"

Bug Description

In keystone curl example document, it uses "curl -d '{"auth":{"passwordCredentials":{"username": "joeuser", "password": "secrete"}}}' -H "Content-type: application/json" http://localhost:35357/v2.0/tokens" to get a token, and in next example, it uses a token to access other service.

Actually without a tenantName in curl body of the first example, the token we get could be used to access other service directly. I think in this example, we could add tenantName in it. It is more meaningful in whole context.

[0] http://docs.openstack.org/developer/keystone/api_curl_examples.html#id3

Revision history for this message
Dolph Mathews (dolph) wrote :

Agree! The example is utilizing default tenancy, which isn't widely utilized.

Changed in keystone:
status: New → Triaged
importance: Undecided → Medium
tags: added: low-hanging-fruit
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

example is missing from http://docs.openstack.org/developer/keystone/api_curl_examples.html#post-tokens, so the token in http://docs.openstack.org/developer/keystone/api_curl_examples.html#get-tenants is not so readable

Changed in keystone:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
ZhiQiang Fan (aji-zqfan)
Changed in keystone:
assignee: ZhiQiang Fan (aji-zqfan) → nobody
Krsna (krsnapc)
Changed in keystone:
assignee: nobody → Krsna (krsnapc)
Krsna (krsnapc)
Changed in keystone:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/77294
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=ae34f84f271f8965b248ffbc9860506a8a7e6951
Submitter: Jenkins
Branch: master

commit ae34f84f271f8965b248ffbc9860506a8a7e6951
Author: Krsna Widmer <email address hidden>
Date: Fri Feb 28 14:52:57 2014 -0800

    Update curl api example to specify tenant

    In the keystone api_curl_examples document, the curl example for
    "POST /tokens" did not specify a tenant. This example utilized
    the default tenant, which is not commonly used. Changed the
    example to include "tenantName" as part of the example to prevent
    future confusion.

    DocImpact

    Closes-Bug: #1269739

    Change-Id: Iaad8c7c5a32bc6cff38c938dd36365cddd6741cb

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.